Closed MrishoLukamba closed 1 month ago
Get the request from the events in this call,
and pass it to this function
so we can avoid this unnecessary search, which is the cause of the flakiness
Get the request from the events in this call,
and pass it to this function
so we can avoid this unnecessary search, which is the cause of the flakiness
The issue of getting the event from this function is I have to wait for tx to be executed ( wait for success) The issue for that is while tx is in block it sometimes yield invalid tx but at the same time the tx is valid and is executed ( hence leading to flakiness), Consider subxt docs below
I will try to construct a Getrequest type and pass it, the issue is it is of different type ( subxt codegen type) and this yield error. But pushing commit soon
I suggest you look into why wait_for_success
is flaky, there's also the option to use wait_for_finalized
.
It's a dev environment, transaction submission should be deterministic.
I will try to construct a Getrequest type and pass it, the issue is it is of different type ( subxt codegen type) and this yield error. But pushing commit soon
You can write a From
implementation
I suggest you look into why
wait_for_success
is flaky, there's also the option to usewait_for_finalized
. It's a dev environment, transaction submission should be deterministic.
should be deterministic yes, the issue is the tx do not fail but when you wait for finalization or sucess it returns tx status and among one status is Invalid, which when returned ( as it is probabilistic) based on their docs. the stream returns Err and breaks the test, meanwhile the tx is actually executed perfectly, So thats why i avoid using waiting for anything
refer to PR #251