Typed WebSocket CloseReason

[GoogleCodeExporter]

This will add the following to the WebSocket CloseEvent

[JsProperty(Name = "code", NativeField = true)]
public  CloseReason CloseReason { get; set; }
...
public enum CloseReason
...

Attached, suggested location.
SharpKit.Html/custom/modules/websocket/CloseEvent.cs

Although it generates clean JavaScript it does result in two properties 
targeting the same JavaScript field(code and CloseReason).
Preferably the code field would have the type but since that was in generated 
code I did not change that.

Original issue reported on code.google.com by Hultqvis...@gmail.com on 16 Nov 2013 at 1:34

Attachments:

• CloseEvent.cs

[GoogleCodeExporter]

Hi, thank you for the patch and all recent bug fixes. Would you like to gain 
write access to our google code svn repository, and be able to commit this 
yourself? If so, just send an email to sharpkit support, and provide a gmail 
address (google apps is ok too). Otherwise I'll commit it for you.

Thanks again!

Original comment by DanelK...@gmail.com on 16 Nov 2013 at 9:48

• Changed state: Accepted

[GoogleCodeExporter]

Thanks, I will give svn a try, this is my google account email which I guess 
would work too.

Is there any guidelines on how to expand the code or is that a matter of 
discussion if it would happen? (I'm already on the mailing list)

Original comment by Hultqvis...@gmail.com on 16 Nov 2013 at 9:58

[GoogleCodeExporter]

Well, there are no specific guidelines, simply look at other code and follow 
the same conventions. After you commit your code, feel free to contact me if 
you want your code to be reviewed.

Thanks!

Original comment by DanelK...@gmail.com on 19 Nov 2013 at 8:09

[GoogleCodeExporter]

As i saw, it's alredy commited by you (16.11.2013). So i will close this issue.

Original comment by sebastia...@gmail.com on 25 Nov 2013 at 3:35

• Changed state: Done
• Added labels: v5.2.8