search

polywock / globalSpeed

Web extension to set a default speed for video and audio
https://chrome.google.com/webstore/detail/global-speed-youtube-netf/jpbjcnkcffbooppibceonlgknpkniiff?hl=en
1.7k stars 196 forks source link

Mute doesn't actually mute? #555

Open jayhlee opened 3 months ago

jayhlee commented 3 months ago

I set a key to mute, but it seems like rather than muting, it just sets the audio to 0%. At least, it does on YouTube.

While it's all the same, there is a weird glitch that occurs occasionally. Namely, when I sometimes try to "mute" audio with the key I set, it'll cause the audio to sometimes not play if after pausing and playing a video.

polywock commented 3 months ago

Hello. Even though it displays as 0%, the mute shortcut works by setting the video's "muted" property to true or false. Not sure why that would cause issues.

Does the issue happen on a specific website?

jayhlee commented 3 months ago

On YouTube, when the audio is muted, the speaker icon has a slash over it to indicate that the video has been muted. But when I select the Mute key I designated (KeyM), the speaker icon does not have a slash over it.

I'm also not sure why it causes issues.

I'm wondering if the issues stems from KeyM being the default, first-party way YouTube allows users to mute audio.

polywock commented 3 months ago

I'm wondering if the issues stems from KeyM being the default, first-party way YouTube allows users to mute audio.

Probably not. Global Speed prevents the website from reacting to Global Speed's shortcuts. For example, if you set Global Speed's mute shortcut to KeyM, Youtube's first-party shortcut won't be triggered anymore.

On YouTube, when the audio is muted, the speaker icon has a slash over it to indicate that the video has been muted. But when I select the Mute key I designated (KeyM), the speaker icon does not have a slash over it.

It's a little jarring, but it's a purely aesthetic issue. The video is muted but Youtube's interface doesn't know that.

jayhlee commented 3 months ago

Thanks for the additional details. Based on what you said, I'm at a loss for why there's that weird glitch that occurs occasionally. After unsetting KeyM to mute and just using the YouTube default, everything seems to work normally. Given I mostly watch YouTube video, I'm fine with that. Thanks much for your help!