polywrap / wrap-cli

Used to create, build, and integrate wraps.
https://polywrap.io
MIT License
170 stars 52 forks source link

change node version to 17.5.0 #1807

Closed krisbitney closed 1 year ago

krisbitney commented 1 year ago

After some experimentation and research, I found that 18.12.1 is the most recent version of node supported by ipfs-http-client at version 48.x.x. Increasing the version of ipfs-http-client poses a problem because the maintainers switched from cjs to esm in version 57.0.0 and imposed a requirement that we target es6. Version 56.x.x doesn't fix the node support issue. My thought was that switching from node 18.5.0 to 18.12.1 would be the least disruptive option.

Note that some expect(error).toBeFalsy(); matchers are removed because node generates experimental fetch API warnings. We still have expect(code).toEqual(0); to make sure the process runs as expected.

After changing node to v18.12.1, I found there is a distinct issue with the infra modules that was fixed by decreasing the node version to 17.5.0.