Separate Concerns, IPFS/ENS Plugins, URI Resolver Interface

polywrap / wrap-cli

Used to create, build, and integrate wraps.

https://polywrap.io

MIT License

170 stars 52 forks source link

Separate Concerns, IPFS/ENS Plugins, URI Resolver Interface #622

Closed dOrgJelli closed 2 years ago

dOrgJelli commented 2 years ago

With the IPFS & ENS plugins, they both implement their respective core functionalities, along with implementing the URI Resolver interface methods.

This causes a "confusion of concerns", and leads to issues like the ones described in this thread: https://discord.com/channels/796821176743362611/908544308876050515/935542806418710548

We should create separate plugins for the IPFS & ENS URI-Resolvers, which depend on the IPFS & ENS wrappers within themselves.

nerfZael commented 2 years ago

With the IPFS & ENS plugins, they both implement their respective core functionalities, along with implementing the URI Resolver interface methods.

This causes a "confusion of concerns", and leads to issues like the ones described in this thread: https://discord.com/channels/796821176743362611/908544308876050515/935542806418710548

We should create separate plugins for the IPFS & ENS URI-Resolvers, which depend on the IPFS & ENS wrappers within themselves.

They will depend on IPFS plugin and ENS wrapper, correct? @dOrgJelli Also, we need to add the FS URI Resolver to this list

nerfZael commented 2 years ago

Added this to the following story: https://github.com/polywrap/monorepo/issues/714

nerfZael commented 2 years ago

IPFS part is blocking: #717

nerfZael commented 2 years ago

Before this is tackled we should merge this PR:

[x] #620 This will allow us to also rewrite the plugins with the new plugin experience

dOrgJelli commented 2 years ago

@nerfZael new plugin devexp has been merged, and will be in versions 0.0.1-prealpha.72+