Fixed maven build for interoperability test.

pomack / thrift4go

Apache Thrift for the Go Language

129 stars 23 forks source link

Fixed maven build for interoperability test. #47

Closed GeertJohan closed 12 years ago

GeertJohan commented 12 years ago

Edited pom.xml, added the maven compiler plugin with config. Must use java 1.6. Java 1.6 allows @Override annotations for methods that implement an interface (which the generated code does). This is also likely to fix the Travis-ci build.

matttproud commented 12 years ago

Aalok, I spoke with Geert-Johan privately about this change. I am not sure why the conformance level was not needed in my local environment nor on Travis before, but it appears to be. The crux of the problem is that Maven compiles the Java classes in a pre-generics mode, yielding syntax errors.

GeertJohan commented 12 years ago

Thanks for clarifying that Matt, I should've mentioned that in the description. BTW: The travis build on this pull request failed because the .travis.yml has "pomack/thrift4go" statically in it. I have added cross-repository travis ability in an other branch which is also requested for pull.