pombase / allele_qc

Quality control for PomBase alleles
MIT License
1 stars 1 forks source link

Changes in description for alleles that have description in the allele name #50

Closed manulera closed 1 year ago

manulera commented 1 year ago

Related to https://github.com/pombase/allele_qc/issues/49 Hi @kimrutherford,

I remember discussing this at some point, but I am not sure what we went for in the end. We had discussed that for alleles that contained the allele description in the name (e.g. name: isu1-D37A, description: D37A), if we found an error in the description we wanted to:

I don't remember if we decided what to do about this, and whether it would be on the Canto or the pipeline side.

cc: @ValWood

ValWood commented 1 year ago

In the case where the name does not match the residues, I think we decided that we would change the name and make the original name a synonym. This way users will know immediately which residue it is, it will be named correctly going forwards, and the original name is findable. (except for histones of course)

manulera commented 1 year ago

But I think we had done something about it already, I don't remember if on my side or @kimrutherford 's side.

manulera commented 1 year ago

I found it, yes. We have a column in change_name_to in allele_auto_fix.tsv that is populated if the description was included in the name and the description has changed.