search

pombase / canto

The PomBase community curation tool
https://curation.pombase.org
Other
19 stars 7 forks source link

Single organism mode: phenotype links missing from gene page #1765

Closed kimrutherford closed 5 years ago

kimrutherford commented 5 years ago

I have phenotypes configured but no link is present in single organism mode:

single-user-gene-page-bug-1

jseager7 commented 5 years ago

I think this is because https://github.com/pombase/canto/pull/1663 didn't discriminate between single- and multi-organism modes. You could revert that commit and make the links display conditionally based on the mode, if you want a quick fix.

jseager7 commented 5 years ago

Personally, I've partly changed my mind about about removing the links after having done it, because when I've been adding single alleles to the session, I often find myself clicking the gene on the summary page instead of going to the genotype management view.

kimrutherford commented 5 years ago

I agree. Now that the host and pathogen ontologies are merged it might be OK again. I've gone with your suggestion and revert that commit.

Maybe we should remove the "Multiple allele Phenotype" link? Or perhaps move it further down the page and rename it to "Genotype management"?

jseager7 commented 5 years ago

Or perhaps move it further down the page and rename it to "Genotype management"?

I think this is probably a better idea to avoid confusing any users that were used to the 'Multiple allele phenotype' link. We could add some extra text to clarify that the new link means the same thing as the old link.

jseager7 commented 5 years ago

I'm going to close this issue for now, since the issue itself is fixed. We can open new issues for any regressions that the revert created.