search

pombase / canto

The PomBase community curation tool
https://curation.pombase.org
Other
19 stars 7 forks source link

Limit AE infective ability to one entry #1997

Open CuzickA opened 5 years ago

CuzickA commented 5 years ago

Whilst curating I often copy and edit existing annotations.

In one case I noticed that I had managed to add 2 AE for infective ability eg 'loss of pathogenicity' and 'unaffected pathogenicity' This was whilst curating the mutant and control (I have since realised I don't need this control for this paper)

I think I must have duplicated the existing entry with its AE and added a new AE without hitting the X to remove the previous AE.

It might be nice to have a pop up warning or a limiter to stop people entering more than one AE here?

I'm not sure whether we would want this to apply to all AEs?

ValWood commented 5 years ago

Sometimes more than one AE is appropriate. We do plan to do some QC reporting in the future so I think we will cover things like this request then.

We can think about which combinations are allowed/not allowed. In the meantime we need to be vigilant about the checking. At PomBAse we also have quite a few QC checks that operate during database loading so this is also an option, but ideally we will bring all the checks forward to prevent the erros.

jseager7 commented 5 years ago

If all of the terms in the 'infective ability' extension are mutually exclusive, then we can restrict the cardinality of that extension to 1 (currently the cardinality is *, meaning one or more). Basically, you'd only be able to add one 'infective ability' annotation extension per annotation.

However, if only some of the extension terms are mutually exclusive, then I'm not sure if Canto can currently handle those sorts of restrictions – at least not with its current capabilities.

kimrutherford commented 5 years ago

However, if only some of the extension terms are mutually exclusive, then I'm not sure if Canto can currently handle those sorts of restrictions – at least not with its current capabilities.

Yep, complicated restrictions aren't possible at the moment.