search

pombase / canto

The PomBase community curation tool
https://curation.pombase.org
Other
19 stars 7 forks source link

Scroll to previous spot when reloading? #2651

Open manulera opened 1 year ago

manulera commented 1 year ago

As it is now when some changes are made to GIs, the whole site is reloaded.

If it is not hard to do, I think it would be good to scroll the page to the same point it was before the reload. I think it would reduce the friction, especially for sessions where several GIs have to be added or where several annotations exist, to quickly come back to where you were before.

manulera commented 1 year ago

cc @ValWood

kimrutherford commented 1 year ago

Unfortunately I don't know of a way to do that.

When there's some time I hope to re-implement the code that handles the annotation tables. After that improvement the page reload won't be necessary.

ValWood commented 1 year ago

This would be a nice improvement. It's an annoying 'feature'

ValWood commented 1 year ago

If there is any possibility to fix this I would put it near the top of the list. Yesterday I needed to deepen a lot of viability and growth phenotypes to vegetative. It probably took about half an hour because of how long it takes to re-find your place.

There was a very similar issue reported here which was fixed, I wonder if this is related fix?

Because you probably won't have time to reimplement the annotation tables any time soon .....

manulera commented 1 year ago

I @kimrutherford maybe something hacky like this would be enough:

https://stackoverflow.com/questions/17642872/refresh-page-and-keep-scroll-position#answer-58743412

ValWood commented 1 year ago

I tried to send a video of how long it took to make the changes in a big session. It was 37 seconds.

kimrutherford commented 1 year ago

Until I have fixed this properly, would it be better to just display a message suggesting that the user reload?:

image

There are other color/style options:

image

kimrutherford commented 1 year ago

Until I have fixed this properly, would it be better to just display a message suggesting that the user reload?:

We decided to make this change only for admins for now.

kimrutherford commented 1 year ago

Until I have fixed this properly, would it be better to just display a message suggesting that the user reload?:

We decided to make this change only for admins for now.

That's done now.

ValWood commented 1 year ago

This is better...close?

kimrutherford commented 1 year ago

This is better...close?

It's still going to be annoying for community curators so I'd rather leave this open to remind me to fix this properly.