search

pombase / canto

The PomBase community curation tool
https://curation.pombase.org
Other
18 stars 7 forks source link

can bypass modification residue checks with duplicate and edit #2803

Closed ValWood closed 2 months ago

ValWood commented 2 months ago

This isn't super urgent, but I noticed that I could copy and edit a modification, and the residues from the precious gene would be accepted, even if no residue at that position:

ticket canto residue check bypass
kimrutherford commented 2 months ago

That's unfortunate! The simplest fix would be to remove the residue extension if you change the gene in the edit dialog. We could put a message box up explaining things. Would that be OK?

ValWood commented 2 months ago

Yes I think that is safest.

kimrutherford commented 2 months ago

The simplest fix would be to remove the residue extension if you change the gene in the edit dialog. We could put a message box up explaining things.

I've implement this now. The change will be in the main Canto on Monday morning. I'll close the issue then.

image