pombase / canto

The PomBase community curation tool
https://curation.pombase.org
Other
18 stars 7 forks source link

cant edit annotations #2815

Closed ValWood closed 1 month ago

ValWood commented 1 month ago

in this session to add new terms? pombe/curs/c56a652b8b068e66

ValWood commented 1 month ago

or this one /pombe/curs/2c52a27e773dd541

but some, I could

cc @PCarme

kimrutherford commented 1 month ago

I just tried to add an annotation in c56a652b8b068e66 and that worked (I removed it afterwards).

Which term were you trying to use in the annotation and which ontology was it?

ValWood commented 1 month ago

i was trying to add increased centromeric inner repeat transcript level as per term request (the edit button is greyed out for me)

kimrutherford commented 1 month ago

There are some edit buttons greyed out for annotations that are part of genotype-genotype interactions:

Changing the genotype would change the interaction in those cases.

PCarme commented 1 month ago

I also had this problem with phenotypes of genotypes involved in multi-locus interactions yesterday. Even for phenotypes that are not involved in the interactions themselves. I had to remove the interactions to be able to edit them.

ValWood commented 1 month ago

Changing the genotype would change the interaction in those cases.

in this case I'm trying to change the annotation not the genotype, and the specific annotation isn't used in an interaction.

kimrutherford commented 1 month ago

the specific annotation isn't used in an interaction.

In the database it is using the whole annotation because the interactions with a phenotype need the term and extension as well as the genotype. So the whole annotation referenced by the interaction:

image

We decided to prevent editing in this case so that changes to the genotype annotation wouldn't change the interaction:

Let's talk about this on Friday.

ValWood commented 1 month ago

Oh actually I see that actual phenotype is used. I can work around by re-making the annotation. we'll talk about it on Friday.

ValWood commented 1 month ago

In the Stachan session I fixed one of the new terms by removing the interaction, adding the new term and adding the interaction back. We probably have to do it like this for the reasons discussed.

However, the remaining one, I can't fix because I can't locate the GI which references it?

I removed the interaction from this one, which does reference it:

Screenshot 2024-03-21 at 11 14 42

but I still could not edit the annotation. I'm assuming it must be references in another GI, but none of the others are about this phenotype?

recording it here because otherwise I might forget that I still need to add the GI back to the annotation above once we locate the other cause!

Can look on Friday.

ValWood commented 1 month ago

this is what I removed

Screenshot 2024-03-21 at 11 21 46
ValWood commented 1 month ago

Clicking on edit will give a message

"changes to this annotation will change xx genetic interactions that it refers to" (or something the same)

kimrutherford commented 1 month ago

This annotation should be editable:

image

https://curation.pombase.org/pombe/curs/c56a652b8b068e66

kimrutherford commented 1 month ago

Clicking on edit will give a message

"changes to this annotation will change xx genetic interactions that it refers to" (or something the same)

How's this?:

image

kimrutherford commented 1 month ago

Clicking on edit will give a message

"changes to this annotation will change xx genetic interactions that it refers to" (or something the same)

I've deployed that change. Let me know if there are any problems.

ValWood commented 1 month ago

Seems to be working for me.

kimrutherford commented 1 month ago

Thanks for testing. I'll close this and we can open new issue if there are any bugs.