pombase / fypo

Fission Yeast Phenotype Ontology
Creative Commons Attribution 4.0 International
14 stars 6 forks source link

vegetative vs non-vegetative (protein modification) #2908

Closed ValWood closed 7 years ago

ValWood commented 7 years ago

Users might find this odd:

drill down1

drill down2

ValWood commented 7 years ago

so, when you drill down there are non vegetative modification terms, but for some you need to look under the vegetative term. Then when you go to the vegetative term, the modifications are not named vegetatively.

I don't think it usually matters, but it seems strange here when we will clearly need to change to "vegetative" eventually. Might be worth calling these vegetative now, and adding a non-vegetative parent for clarity.

mah11 commented 7 years ago

I can edit term names; I won't bother adding generic parents until we need them to group any siblings that are actually not vegetative (as opposed to unspecified).

ValWood commented 7 years ago

Yeah that makes sense...

mah11 commented 7 years ago

have started this slog; it's going to take several goes 'cos it's too tedious to do all at once

ValWood commented 7 years ago

oh I thought you were only doing it for these terms....

I think it makes sense where the terms are split like this.... we can say when it looks a bit odd when we "drill down"

mah11 commented 7 years ago

yeah, I'm mainly just doing the protein modification branch for now, but there are tons because of all the histone this-or-that-modification on this-or-that residue terms ...

mah11 commented 7 years ago

I've got as much of this done as I wanted to for this ticket, namely the protein modification branch. Open a new ticket for the next area that should get the refit (preferably not too soon ;) ).

ValWood commented 7 years ago

yep will avoid that for a while...