pombase / fypo

Fission Yeast Phenotype Ontology
Creative Commons Attribution 4.0 International
15 stars 6 forks source link

Microtubule dynamics - phenotype ontologies #4126

Closed manulera closed 2 years ago

manulera commented 2 years ago

Based on the following issue: https://github.com/manulera/discussions_curation/issues/4

ValWood commented 2 years ago

Proposed changes

  1. Rename FYPO:0000901 to abnormal microtubule dynamics during vegetative growth. Then make four children:

Good catch ! Note that I added abnormal microtubule polymerization (FYPO:0004614) as a parent of abnormal kinetochore microtubule polymerization during mitotic metaphase chromosome recapture (FYPO:0006040) (I did not use a rate term because FYPO:0006040 does not currently mention rate, but this can be further amended if necessary).

  1. Edit the synonyms as well.

Requested terms - MT dynamics

Requested terms - My paper

Change in synonyms

These are either for FYPO:0000901, or for the terms that were already specific and mentioned growth/shrinkage rate.

Action Term name/ id Existing synonym Proposed change Reason
Action FYPO:0000901 all None I guess they can be left like this, since they mention both growth and shrinkage
Action FYPO:0003193 normal rate of microtubule catastrophe remove Catastrophe, not depolymerisation.
Action FYPO:0003194 The ones that mention stability and catrastrophe remove Catastrophe, not depolymerisation.
Action FYPO:0003190 The ones that mention stability and catrastrophe remove Catastrophe, not depolymerisation.
Action FYPO:0007111 catastrophe remove Catastrophe, not depolymerisation.
ValWood commented 2 years ago

revised: FYPO:0000901 new def A cellular process phenotype observed in the vegetative growth phase of the life cycle in which microtubule growth (polymerization), catastrophe (the transition from growth to shrinkage), shrinkage (depolymerization), or rescue (the transition from shrinkage to growth) is abnormal.

Usually we would need to obsolete a term if we change the meaning of the definition, but here since the change is subtle, and was encapsulated by annotations to this term, I have altered the def.

ValWood commented 2 years ago

I could not add an equivalence axiom for "abnormal rate"

but he child terms have them: 'has part' some ('increased rate' and (happens_during some 'mitotic interphase') and (happens_during some 'single-celled organism vegetative growth phase') and ('inheres in' some 'microtubule polymerization'))

@nicolevasilevsky @matentzn how do I get "abnormal rate" for this grouping term for rate phenotypes? For I request this from PATO, or somewhere else? It seems odd not to be able to create an equivalence axiom for the parent went he children have them.

matentzn commented 2 years ago

the abnormal part goes in the EQ, not the PATO class:

'has part' some
('increased rate'
and (happens_during some 'mitotic interphase')
and (happens_during some 'single-celled organism vegetative growth phase')
and ('inheres in' some 'microtubule polymerization') 
and ('has modifier' some 'abnormal')
)

Why is it necessary to have 2 'happens during' clauses? There should be just one ideally.. Do these phases happen at the same time?

ValWood commented 2 years ago

the abnormal part goes in the EQ, not the PATO class:

OK that part makes sense. So probably I cant create a definition for a grouping term for "increased or decreased" rate?

Why is it necessary to have 2 'happens during' clauses? There should be just one ideally.. Do these phases happen at the same time?

I have no idea why there are 2, this was an existing logical def I am copying and adjusting. I don't really understand their construction....

Looking at this the and (happens_during some 'single-celled organism vegetative growth phase') looks as though it is redundant with and (happens_during some 'mitotic interphase')

I think what has likely happened is that the 'single-celled organism vegetative growth phase' has been retained when a more specific term and equivalence axiom has been added. We can look for logical defs with 2 happens_during and revise. In the meantime I removed the redundant looking one from FYPO:0004615. to see what happens.

matentzn commented 2 years ago

So probably I cant create a definition for a grouping term for "increased or decreased" rate?

of course, just use rate in the grouping term, increased rate in the child, then you have the grouping! Or did you mean something else?

ValWood commented 2 years ago

doh, got it ! Thanks.