pombase / pombase-chado

PomBase code for accessing Chado
MIT License
5 stars 3 forks source link

Display 'binding and ' active site' from UniPRot #1172

Closed ValWood closed 2 months ago

ValWood commented 6 months ago

This is quite hidden unt her the function section in a subsection 'features' So this is different from the "PTM-type" features

It seemed to include only: binding site and catalytic site, but there may be more

These could be 1 track or 2 tracks

eg

Screenshot 2024-05-08 at 16 13 09

need to acknowledge UniProt as source in the pop-up

ValWood commented 6 months ago

Sorry!. Now I can't remember what that was. Here is a different one https://www.uniprot.org/uniprotkb/Q9P376/entry#function

ValWood commented 4 months ago

This ticket is related to website https://github.com/pombase/website/issues/2159

ValWood commented 4 months ago

Also related, although a different datatype https://github.com/pombase/pombase-chado/issues/1172

kimrutherford commented 4 months ago

See also:

kimrutherford commented 4 months ago

I've had a look at the data from the UniProt file (https://github.com/pombase/pombase-chado/issues/52).

For binding site we get:

For active sites we get:

We need to decide which of these qualifiers we want to display.

kimrutherford commented 4 months ago

Also related, although a different datatype https://github.com/pombase/pombase-chado/issues/1172

1172 is this issue?

kimrutherford commented 4 months ago

I've added the code for binding sites and active sites in time for the current load. Here's how it looks:

image

Let me know if we should change the formatting of the text in the mouse-over for binding sites.

The new display is on my desktop for now: https://desktop.kmr.nz/gene/SPAC11E3.13c It should be on the main site in the morning.

kimrutherford commented 3 months ago

It should be on the main site in the morning.

That's live now: https://www.pombase.org/gene_protein_features/SPBC1105.02c

kimrutherford commented 3 months ago

I forgot to say: for now the binding and active sites are only shown on the full view, not in the widget on the gene pages.

ValWood commented 3 months ago

That's live now:

nice!

ValWood commented 3 months ago

I think full view is OK.

kimrutherford commented 3 months ago

I'll add something to the docs before closing: https://www.pombase.org/documentation/gene-page-protein-features-widget

kimrutherford commented 3 months ago

I'll add something to the docs before closing: https://www.pombase.org/documentation/gene-page-protein-features-widget

I've added this documentation by copy and pasting from the UniProt track descriptions. Is this OK?

ValWood commented 3 months ago

Sounds good except Signal peptide N-terminal signal peptide position, imported from UniProt should be a mixture of imported, curated, and running signal peptide locally

kimrutherford commented 3 months ago

I think all the signal peptides in the protein feature viewer are from UniProt, because they have positions.

ValWood commented 3 months ago

I think all the signal peptides in the protein feature viewer are from UniProt, because they have positions.

yes they seem to be. I think we need to get the others from phobius to fil in the gaps.

ValWood commented 2 months ago

I think this can close?