pombase / pombase-config

Shared configuration for PomBase projects
0 stars 2 forks source link

has_regulation_target #92

Closed ValWood closed 1 year ago

ValWood commented 1 year ago

PMID:27183195 & PMID:18280239 & PMID:22323607

GO:0170008 | mRNA phosphatase activator activity | IDA |   | has_regulation_target dcp2

has_regulation_target is the relation, and display label in Canto. we can change this to "has_input" as the relation, with the display label "activates"

ValWood commented 1 year ago

PMID:34086083

similarly GO:0001228 | DNA-binding transcription activator activity, RNA polymerase II-specific can be has_input with display label "activates transcription of"

but oddly others look like this:

Screenshot 2023-02-24 at 17 38 20

which is similar to the problem I reported the other day?

kimrutherford commented 1 year ago

GO:0170008 | mRNA phosphatase activator activity | IDA | | has_regulation_target dcp2

has_regulation_target is the relation, and display label in Canto. we can change this to "has_input" as the relation, with the display label "activates"

It now has "regulates activity of" on the GO:0170008 page. Is that correct or should it be "activates"?

GO:0001228 | DNA-binding transcription activator activity, RNA polymerase II-specific can be has_input with display label "activates transcription of"

but oddly others look like this:

It now says "activates transcription of mug14" on the rst2 page: https://www.pombase.org/gene/SPAC6F12.02

ValWood commented 1 year ago
  1. All of the molcular function activators say https://www.pombase.org/term/GO:0140677 "regulates activity of"

    • "activates" would be better here.
  2. Note to self, there are still some annotations where the incorrect extension relation is hard-wired in legacy curation, need updating: jac1, swr1, map2, mmf1-3

kimrutherford commented 1 year ago

All of the molcular function activators say https://www.pombase.org/term/GO:0140677 "regulates activity of"

"activates" would be better here.

This is the current configuration for "regulates activity of":

        {
            "rel_name": "has_input",
            "if_descendant_of": "GO:0030234",
            "display_name": "regulates activity of",
            "reciprocal_display": "activity regulated by"
        }

I've changed it to "activates" with reciprocal "activated by". If that's OK we can close this.

The change will be visible on Tuesday morning.

ValWood commented 1 year ago

ATPase activator activity (GO:0001671): appears to be hardwired to directly_positively_regulates , this should also be activates

ValWood commented 1 year ago

GO:0000772 | mating pheromone activity should also be "activates"

GO:0000772
mating pheromone activity

kimrutherford commented 1 year ago

OK, I've added configuration to display "has_input" as "activates" on the website for GO:0001671 and GO:0000772. And I've added the config so that those extensions can be added in Canto. The Canto changes will be visible in the morning. The website will be visible on Thursday morning.

The annotation with directly_positively_regulates in Canto will need to be changed to has_input/activates.

ValWood commented 1 year ago

I fixed the remaining problem annotations to has_input, closing