pombase / website

PomBase website v2
MIT License
6 stars 1 forks source link

new page type. All alleles of this gene #1255

Closed ValWood closed 9 months ago

ValWood commented 5 years ago

Discussed on group call that such a page would be a useful addition.

ValWood commented 9 months ago

Oh this is going to be soooo useful for everyone!

ValWood commented 9 months ago

One sma;ll. thing I just notices. When you list the genotypes, can you make the allele itself be at the top of the list?

kimrutherford commented 9 months ago

When you list the genotypes, can you make the allele itself be at the top of the list?

Sorry, I don't follow. Do you want to show the allele in the list of genotypes?

ValWood commented 9 months ago

In the example above, it woud be better if sup35(G)(Nt) genotype was above the mutigene genotypes (I was just slightly confused by it), and for alleles used in a lot of multi-alleles I think it would be better.

kimrutherford commented 9 months ago

So put the single allele genotypes first?

ValWood commented 9 months ago

I think so, or they may get lost in the long lists, especially for some cdc2 alleles

kimrutherford commented 9 months ago

I've changed the order so genotypes with fewer loci come first. Also haploids come before diploids.

kimrutherford commented 9 months ago

The outstanding tasks for this issue:

kimrutherford commented 9 months ago

move deletion and WT alleles out of table to top of page

I've implemented that on a branch which I'll merge once we have allele pages.

It currently looks like this:

image

kimrutherford commented 9 months ago

I've added the "View genotypes..." links back which got lost in the changes:

image

kimrutherford commented 9 months ago

How about instead of the "Show genotypes.." link, could we link to the allele pages once they're done? add a title / tooltip

That's all done on the branch.

kimrutherford commented 9 months ago

line wrap the descriptions at around 50 chars

I've changed the alleles table so that the name and descriptions wrap (on the branch). Maybe good enough for now.

image

kimrutherford commented 9 months ago

This issue is long and I think it's more or less done. Or I'll close it and we can open new issues for changes.