search

pombase / website

PomBase website v2
MIT License
6 stars 1 forks source link

Redundant lines in coq7 "Target of" section #1831

Open kimrutherford opened 2 years ago

kimrutherford commented 2 years ago

The "substrate of" line shouldn't be there:

target-of-bugs-coq7-1

(Noticed while working on pombase/pombase-config#85)

kimrutherford commented 2 years ago

Oh you fixed it!

Unfortunately not. I forgot to mention that the summary shows just one annotation. There are two in the detailed view.

kimrutherford commented 2 years ago

I had a look into this. It isn't exactly a bug, it just what we've configured in extension_display_names: the "substrate of" is because the term is a descendant of GO:0003824 and "dephosphorylated by" is because it's a descendant of GO:0004722

The code isn't smart enough to only use the more specific configuration.

kimrutherford commented 2 years ago

OK, there is a way to negate parents in the config file. I will try to figure it out...

I don't remember implementing that. Are you thinking of something else?

kimrutherford commented 2 years ago

I think I should be able to fix the code to remove the redundancy but I'll need to get my thinking head on. Now I know it's not a bug, it's not so urgent. I'll put this on low priority for now.