pombase / website

PomBase website v2
MIT License
6 stars 1 forks source link

allele comments vs. genotype comments #1919

Open ValWood opened 1 year ago

ValWood commented 1 year ago

Follow on from https://github.com/pombase/website/issues/1916

The 'allele comment' is a fairly recent thing., Historically we put "allele comments' in the genotype comments field. I suspect 99.9% of single allele genotype comments are actually allele comments (and probably genotype comments is not used much, but I am not sure about that).

Could we get a list of

  1. single allele genotype comments
  2. multi-allele genotype comments to confirm this and then decide if we need to migrate single allele genotype comments to allele comments
kimrutherford commented 1 year ago

These are both tab separated files:

single_locus_genotype_comments.tsv.txt

multi_locus_genotype_comments.tsv.txt

ValWood commented 1 year ago

All of the single locus genotype comment are really single allele comments except for:

I don't understand this comment?

Unecessary

Need discussion

Ectopic localisation phenotype

Other Phenotype

Degron https://github.com/pombase/curation/issues/3319

Chimera follow https://github.com/pombase/curation/issues/3321

Fix https://github.com/pombase/curation/issues/2930

ValWood commented 1 year ago

So, we will fix the above, and everything for single allele can migrate to be an allele comment" Do we need to maintain allele comments outside of Canto?

ValWood commented 1 year ago

multi locus geneotype comments

Comment seem as though they belong on one of the contributing alleles (although comment could be inherited)

Phenotype

Not required

Comment does not make sense

Chimera not usually a multi -allele genotype?

TeV fusion not usually a multi -allele genotype?

Look like a single allele genotypes?

Degron should be represented in single allele description

True genotype comment

P81nmt should be in allele name:

Discuss nak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayedpmo25-35-T236A-nucleotide_mutation-expression-not_assayed nak1+ and orb6+ wild type product levels mor2-786-A1673G-nucleotide_mutation-expression-not_assayednak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayed nak1+ and orb6+ wild type product levels cdc3-124-E43K-amino_acid_mutation-expression-not_assayednak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayed nak1+ and orb6+ wild type product levels nak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayedorb6-25-unknown-unknown-expression-not_assayed nak1+ wild type product level nak1-167-unknown-unknown-expression-not_assayednak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayed orb6+ wild type product level nak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayedsid2-250-unknown-unknown-expression-not_assayed nak1+ and orb6+ wild type product levels cdc16-116-unknown-unknown-expression-not_assayed__cdc3-124-E43K-amino_acid_mutation-expression-not_assayed__nak1-orb6-Nterm-GPF-Nak1-Orb6-Cterm_fusion-other-expression-not_assayed nak1+ and orb6+ wild type product levels

dcr1delta__med31-ins-F23-LVRIC-amino_acid_insertion-expression-not_assayed hypomorphic Med31 allele from Dicer G0 suppressor screen par1delta__spg1-106-unknown-unknown-expression-not_assayed loss of function

ValWood commented 1 year ago

We can discuss this. Once your part is done (we can decide when we speak) this ticket can transfer to the curation tracker for the tidy up.

kimrutherford commented 1 year ago

So, we will fix the above, and everything for dingle allele can migrate to be an allele comment" Do we need to maintain allele comments outside of Canto?

We could move them to pombe-embl/supporting_files/allele_comments.txt or we could enable adding comments as allele notes in Canto like FlyBase do, then move them inside Canto to be notes.

image

image

kimrutherford commented 5 months ago

Put off until we have allele page, then discuss.

Curators will then need to review the comments.