search

pombase / website

PomBase website v2
MIT License
6 stars 1 forks source link

small change to assigned by display in pop ups #2243

Open ValWood opened 3 days ago

ValWood commented 3 days ago

As I was writing the announcement I was thinking that perhaps we should not show "assigned by Pombase"

i.e.

cdc25 modification

and only show for imported residues. But instead of showing assigned by Unipart, we should say imported from uni product, i.e. imported from where ever it is in the assigned by Column, when it isn't PomBase.

It would be less cluttered and more accurate, and "saaigned by pombase" might look strange to the community curators

ValWood commented 3 days ago

also the ordering, I think the evidence should come before the citation.

"imported by", when required, can be at the end

kimrutherford commented 3 days ago

I've made those changes. It will be on the main site on Saturday morning.

ValWood commented 3 days ago

So, if there are cases where it isn't an N at this position, where will that be reported, I can't remember

kimrutherford commented 3 days ago

So, if there are cases where it isn't an N at this position, where will that be reported, I can't remember

The results of Manu's pipeline are here: https://github.com/pombase/allele_qc/tree/master/results

There are lots of errors here: https://github.com/pombase/allele_qc/blob/master/results/protein_modification_cannot_fix_other_errors.tsv mostly because the UniProt positions don't have a residue at the start.

Errors about incorrect residues should appear there too.