Ability to sort slim results on gene column

ValWood commented 1 month ago

I wondered if this would be easy to do:

It would be nice to be able to rank these by number

kimrutherford commented 1 month ago

I wondered if this would be easy to do:

It's probably 2-3 hours work.

ValWood commented 1 month ago

OK, it would be good to do sometime....

kimrutherford commented 3 weeks ago

Which order should the rows be when you sort by gene count? Largest count at top or bottom?

kimrutherford commented 3 weeks ago

Which order should the rows be when you sort by gene count? Largest count at top or bottom?

I've implemented this with the smallest at the top for now - very easy to change. Most other places where we sort by a column of numbers we use that order, like the literature section of gene pages and on the results pages for things like protein length.

There are two different types of slim pages. There is the slim overview:

https://www.pombase.org/browse-curation/fission-yeast-bp-go-slim-terms

and the pages of slimmed gene results sets:

https://www.pombase.org/slim:mf_goslim_pombe/from/id/c57703f2-6762-40d7-bfa9-a67d150ec59f

The first case was very simple to implement, but the second case was slightly more involved. If you see an bugs it will likely be in the second case. Let me know if there are problems.

This will be on pombase.org in the morning.

The nightly update is running a little late because I broke things implementing modification filtering and had to restart. It should be done by 8am UK.

Also available on my desktop: https://desktop.kmr.nz/browse-curation/fission-yeast-bp-go-slim-terms

kimrutherford commented 3 weeks ago

This will be on pombase.org in the morning.

Now live: https://dev.pombase.org/browse-curation/fission-yeast-bp-go-slim-terms

ValWood commented 3 weeks ago

by gene count? Largest count at top

please!

ValWood commented 3 weeks ago

Looks good! for both types of pages

kimrutherford commented 3 weeks ago

by gene count? Largest count at top

please!

Is it OK that that's inconsistent?

ValWood commented 3 weeks ago

inconsistent with what? The ones we are most interested in are the annotated bins. Otherwise I need to scroll to the bottom and read it backwards?

kimrutherford commented 3 weeks ago

inconsistent with what? The ones we are most interested in are the annotated bins. Otherwise I need to scroll to the bottom and read it backwards?

See: https://github.com/pombase/website/issues/2246#issuecomment-2451249432

I've implemented this with the smallest at the top for now - very easy to change. Most other places where we sort by a column of numbers we use that order, like the literature section of gene pages and on the results pages for things like protein length.

So I'm wondering if it's OK to be inconsistent?

PCarme commented 3 weeks ago

I think this "inconsistency" is OK since the ordering by gene count will serve different purposes:

For the Literature section, you want the lowest gene counts at the top to see the papers that are specific to the gene you are looking at first, and all the high throughput assays "hidden" at the bottom of the list.
For the slims, I think the idea is to see the terms that are the most annotated, so the "most interesting" first.

ValWood commented 3 weeks ago

Thanks for the explanation. I agree, they have different purposes so the inconsistency is OK

kimrutherford commented 3 weeks ago

OK, thanks.

I've re-released with the largest gene count at the top.

pombase / website

Ability to sort slim results on gene column #2246