search

pombase / website

PomBase website v2
MIT License
6 stars 1 forks source link

Make genes pages look more like publication pages #769

Closed kimrutherford closed 6 years ago

kimrutherford commented 6 years ago

I think the publication pages look better than the gene pages. I like that they are left-aligned.

The gene name and the details are centred on the gene page. I think we should consider left-aligning the gene page too.

I also think that the top of the SGD gene pages looks better than our gene pages:

sgd-gene-page-1

I think the gene name looks a bit small and lost on our gene pages:

pombase-gene-page-1

kimrutherford commented 6 years ago

I think the publication pages look good. The title size is a better match for the page:

pombase-pub-page-1

ValWood commented 6 years ago

I agree. The only bit of our website I'm not keen on is the top of the gene pages. I think we should go with left aligned. This will hoever make the section somewhat longer (although there is always line wrapping, so it will only be 2 lines longer. Closing the gap between the name and the other top matter will help a bit.

Go for it!

kimrutherford commented 6 years ago

I'll change it locally at some point and attach a screenshot for us to discuss.

kimrutherford commented 6 years ago

I've been playing with the look of the gene pages. Below is a sample.

new-gene-page-look

ValWood commented 6 years ago

well thats better already!

Antonialock commented 6 years ago

Yes though I think the size of the text in the quicklinks could be increased slightly...it's relatively hard to read

kimrutherford commented 6 years ago

Yes though I think the size of the text in the quicklinks could be increased slightly

I'll increase it a bit. I don't want to make it too big to avoid the menu going off the bottom of the screen.

kimrutherford commented 6 years ago

well thats better already!

I'll do a bit more tuning before releasing the changes. (Also my changes have made the publication pages worse - need to fix that)

ValWood commented 6 years ago

I'll increase it a bit. I don't want to make it too big to avoid the menu going off the bottom of the screen.

The size has never bothered me, I don't think it needs to be any bigger, but we can try it and see....

kimrutherford commented 6 years ago

I'm about to deploy my changes. I'd like to improve the annotation tables too, but that will have to be later.

As well as the gene pages, I've tweaked the term pages to put the term name first as it's more meaningful to most users. Easy to undo if you don't like that change.

Term page before:

term-before-1

Term page after:

term-after-1

ValWood commented 6 years ago

I prefer it your way.