search

pombreda / base2

Automatically exported from code.google.com/p/base2
0 stars 0 forks source link

style.setProperty on IE doesn't convert 'float' to 'styleFloat' #108

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
In "DOM/style/CSSStyleDeclaration.js", in the definition for
"CSSStyleDeclaration", under the code block "@MSIE.+win", the function
'setProperty' which reads:

{{{
if (priority == "important") {
     style.cssText += format(";%1:%2!important;", propertyName, value);
} else {
     style.setAttribute(ViewCSS.toCamelCase(propertyName), value);
}
}}}

doesn't fix 'styleFloat' as getPropertyValue above does:

{{{
getPropertyValue: function(style, propertyName) {
     return propertyName == "float" ? style.styleFloat :
style[ViewCSS.toCamelCase(propertyName)];
}
}}}

Original issue reported on code.google.com by timcamer...@gmail.com on 9 May 2009 at 7:10

GoogleCodeExporter commented 9 years ago 
Additionally, for MSIE, CSSStyleDeclaration should be bound to element.style 
objects,
which works fine (until cssText is overwritten, in which case the function 
bindings
turn into functions).

Original comment by timcamer...@gmail.com on 9 May 2009 at 7:56

GoogleCodeExporter commented 9 years ago

Original comment by dean.edw...@gmail.com on 21 Jun 2009 at 4:05

GoogleCodeExporter commented 9 years ago 
re comment #1:

Binding the style object results in much slower binding times for MSIE.

Do you really need this?

Original comment by dean.edw...@gmail.com on 7 Jul 2009 at 5:05

GoogleCodeExporter commented 9 years ago

Original comment by dean.edw...@gmail.com on 7 Jul 2009 at 5:33