Closed GoogleCodeExporter closed 9 years ago
Forgot the labels
Original comment by doek...@gmail.com
on 17 Jul 2007 at 8:17
I like it. I originally wrote the exec() method as if it were the replace()
method of
a string. I changed it because I didn't want base2 to mess with
String.prototype.
I'll manually add your changes to my local copy (I just changed RegGrp myself
but
nothing so cool).
Good work.
Original comment by dean.edw...@gmail.com
on 17 Jul 2007 at 9:15
Thanks.
You also might want to remove a comment from RegGrp/Item.js:
// - add one because each pattern is itself a sub-expression
and this variable look dead to me:
var i = this.length + 1;
Original comment by doek...@gmail.com
on 17 Jul 2007 at 9:37
I'm taking ownership of this bug. I'll try to merge in your changes soon.
Original comment by dean.edw...@gmail.com
on 17 Jul 2007 at 9:38
OK. I've checked in your changes.
Original comment by dean.edw...@gmail.com
on 23 Jul 2007 at 9:06
Original issue reported on code.google.com by
doek...@gmail.com
on 17 Jul 2007 at 5:32