pombreda / dicompyler

Automatically exported from code.google.com/p/dicompyler
0 stars 0 forks source link

Missing "model.py" in build of 2/17/2011 #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Using build from 2/17/2011, ./main.py requires deleted model.py
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
Build 2/17/2011 on Ubuntu 10.04

Please provide any additional information below.
Removing reference in plugin.py and anonymize.py allows ./main.py to compile. 
Still checking functionality of build.

Original issue reported on code.google.com by bton...@gmail.com on 22 Feb 2011 at 1:18

GoogleCodeExporter commented 9 years ago
I can confirm this with the changes from 17 Feb 2011 (Revision: d38cd018fc) on 
Ubuntu 10.04.

I didn't catch this at first, because I still had a model.pyc floating around 
on my system.

Adit will need to look at this as far as full functionality. It was the plan to 
remove the dependency on elixir, which was in model.py.

This is a good testament for using the idiom of

import x as y

rather than

from x import *

since the former makes it much easier to strip out x later on (among other 
things).

Thanks for the report.

Original comment by roy.coding@gmail.com on 22 Feb 2011 at 8:37

GoogleCodeExporter commented 9 years ago
Thanks for catching this. I forgot to remove the references to model.py in 
preferences.py and anonymize.py when removing the dependencies on elixir.

I have tested and fixed the issue with a clean checkout and it seems to work 
fine. Anonymization works fine after the fix.

Original comment by bastula on 23 Feb 2011 at 3:56

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 931542c507.

Original comment by bastula on 23 Feb 2011 at 3:58