search

pombreda / django-grappelli

Automatically exported from code.google.com/p/django-grappelli
Other
0 stars 0 forks source link

No Save button for list-editables #221

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create "list-editables" in admin
2. Go to list page
3. Change a list editable

What is the expected output? What do you see instead?

There should be a save button to save your changes. There is none.

What version of the product are you using? On what operating system?
Grappelli 2.1. 

Please provide any additional information below.

Original issue reported on code.google.com by dmee...@gmail.com on 13 Jun 2010 at 6:14

GoogleCodeExporter commented 9 years ago

Original comment by sehmaschine on 13 Jun 2010 at 7:34

GoogleCodeExporter commented 9 years ago 
could you be a little bit more specific?

what fields are you trying to edit?

is there a js-error?

Original comment by klemens.mantzos on 13 Jun 2010 at 8:49

GoogleCodeExporter commented 9 years ago 
In the admin, you can specify fields in your model that are editable on the 
change list page. Because you have hidden the "Save" button on this page, this 
no longer works as it should. 

In your JS, you have made the actions dropdown appear when you click a checkbox 
to apply actions. In the same way, a "Save" button should appear when you 
change a list editable field. 

This is the html that I believe is being hidden (either in the CSS or JS):

<!-- SUBMIT ROW -->

            <div id="submit" class="module footer" style="display: none;">
                <ul class="submit-row">
                    <li class="left delete-link-container"><a href="javascript://" class="cancel-link">Cancel</a></li>
                    <li class="submit-button-container"><input type="submit" class="default" name="_save" value="Save"/></li>
                </ul>
            </div>

http://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.Mod
elAdmin.list_editable

Original comment by dmee...@gmail.com on 13 Jun 2010 at 10:17

GoogleCodeExporter commented 9 years ago 
as soon as you focus an input field in the change_list you should see a footer 
with a cancel and a save button. see attachment.

so please tell me what kind of fields you trying to edit and if you get an js 
error on the change_list onload or onfocus. thx

Original comment by klemens.mantzos on 14 Jun 2010 at 8:40

Attachments:

GoogleCodeExporter commented 9 years ago 
Ok, I see what you mean... 

The error is occurring with checkboxes.  You are right that it works with other 
types of input field.

Thanks.

Original comment by dmee...@gmail.com on 14 Jun 2010 at 1:02

GoogleCodeExporter commented 9 years ago 
checkboxes???

PLEASE tell me what KIND of fields you try to edit.

i.e. BooleanField or NullBooleanField (those two work as expected)

AND PLEASE tell me if you get a js error.

thx

Original comment by klemens.mantzos on 14 Jun 2010 at 1:41

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
It is a BooleanField, which displays as a checkbox. Does not work as expected 
in Safari 5. I do not see a specific JS error.

Works properly in Firefox 3.6.

sorry for the confusion.

Original comment by dmee...@gmail.com on 14 Jun 2010 at 2:22

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1070.

Original comment by klemens.mantzos on 14 Jun 2010 at 3:15