pombreda / django-grappelli

Automatically exported from code.google.com/p/django-grappelli
Other
0 stars 0 forks source link

Actions should require confirmation click #380

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In vanilla admin, actions require a additional click to run. In Grappelli 
actions are instantly executed. This can lead to misclicks damaging large 
amounts of data.

In Django documentation an example action is called "make published". This may 
not have it's own confirmation page the way delete does. By required two clicks 
to run the action, the user would likely catch any mistake. I realize this may 
be an opinion, but because the official Django docs encourage users to make 
fairly important changes without their own confirmation, grappelli should 
respect this. This will also make moving existing projects to grappelli easier. 

At least one user has mistakenly changed a large section of data on my project 
as a result of this because they were not expecting it to just suddenly run an 
action.

Original issue reported on code.google.com by dmbs...@gmail.com on 23 Jun 2011 at 4:28

GoogleCodeExporter commented 9 years ago
a couple of thoughts:
1. if the user shouldn´t change something without a confirmation, you should 
add a confirmation page to your action ... right?
2. therefore, is it really about grappelli respecting this issue or you to 
write a confirmation-page? because a go/submit-button is not a confirmation IMO.
3. I see the point if you´re switching from the original admin-interface to 
grappelli. on the other hand, it´s different interfaces and you need to tell 
your "trusted editors" about these differences.

what do you think?

Original comment by sehmaschine on 1 Jul 2011 at 7:40

GoogleCodeExporter commented 9 years ago
1. It's certainly easy to place a confirmation page.

2. This is fair, but I do think you are deviating a little from what I got when 
reading Django Admin actions documentation. I made this case above with the 
"make published" example. It's fair for a project like this to deviate, but it 
should be considered. A select box is VERY easy to fat finger. I could even see 
someone going to select an action, changing their mind, and clicking on 
whatever just to get rid of the select box. It's unusual behavior for a select 
box to instantly submit a form. But I do see the value in not having two 
confirmation clicks.  

3. Yes this is the major point. In my case I didn't think about the change and 
the result was a poorly implemented action. There are also plenty of cases like 
"make published" where data I think it makes more since to not have a separate 
confirmation page. 

IMO grappelli should use the go/submit-button. It makes it easier to migrate 
projects and I think it serves as a light confirmation for "make published" 
type actions that change data but aren't irreversible like delete. But I 
certainly wouldn't be upset if you disagree.

Original comment by dmbs...@gmail.com on 1 Jul 2011 at 3:04