pombreda / feedparser

Automatically exported from code.google.com/p/feedparser
Other
0 stars 0 forks source link

GUID's are always treated like relative URI's #296

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Process feed "http://feeds.thebrowser.com/BestOfTheMoment?format=xml"
>>> d = 
feedparser.parse("http://feeds.thebrowser.com/BestOfTheMoment?format=xml")

2. All items in this feed have GUIDs as, e.g., 
<guid isPermaLink="false">41253 at http://thebrowser.com</guid>
so GUIDs should not be assumed to be URIs, and GUIDs should not be expanded

3. But GUIDs are expanded in creating IDs (and they are expanded 
inconsistently, resulting in duplicate items); e.g., for item above: 
>>> d['entries'][5].id
u'http://thebrowser.com/best/41253 at http://thebrowser.com'

What is the expected output? What do you see instead?
GUIDs with isPermaLink="false" should not be modified in creating IDs. But they 
are expanded (inconsistently) to create invalid URIs

What version of the product are you using? On what operating system?
Testing with feedparser 5.0.1 and python 2.6.4 under Win7 x64

Please provide any additional information below.
This issue was supposedly fixed in Issue 107.

Original issue reported on code.google.com by johnx...@gmail.com on 27 Jun 2011 at 10:09

GoogleCodeExporter commented 9 years ago
Shwoops! In issue 107 the test case I wrote passes because I didn't include an 
xml:base that would expose the problem! I won't guarantee this will get fixed 
for the upcoming 5.1 release. This is happening because relative URI resolution 
is embedded in `pop()`, and that function needs to be rethought to make fixing 
this and other things possible.

Original comment by kurtmckee on 16 Sep 2011 at 3:04

GoogleCodeExporter commented 9 years ago

Original comment by kurtmckee on 12 May 2013 at 7:22

GoogleCodeExporter commented 9 years ago
This issue was closed by revision dc3bd29bfc1b.

Original comment by kurtmckee on 12 May 2013 at 7:23