search

pombreda / feedparser

Automatically exported from code.google.com/p/feedparser
Other
0 stars 0 forks source link

Rename sgmllib3.py to _feedparser_sgmllib.py and install it when using Python 3 #311

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I suggest that sgmllib3.py be renamed to _feedparser_sgmllib.py and that 
setup.py run by Python 3 automatically install _feedparser_sgmllib.py.

I'm attaching the patch. Changes in feedparser.py are mainly reindentation, as 
you can see in output of `svn di -x-w`.

(If sgmllib3.py / _feedparser_sgmllib.py wasn't already modified by 2to3, then 
subclassing of setuptools.command.build_py.build_py wouldn't be needed.)

Original issue reported on code.google.com by Arfrever...@gmail.com on 5 Dec 2011 at 9:44

Attachments:

GoogleCodeExporter commented 9 years ago 
I don't want to maintain the sgmllib module for Python 3, I just want to 
provide it in the distribution as a courtesy until an alternative illformed XML 
parser can be found for Python 3. As it is, I've discovered that by including 
sgmllib3.py the Arch Linux distribution has created a separate Python 3 sgmllib 
package and has linked it to the feedparser project. This is not something I 
want.

If people want to install sgmllib using setup.py they can probably just use 
sgmllib3k, available on PyPI:

http://pypi.python.org/pypi/sgmllib3k/

Original comment by kurtmckee on 10 Dec 2011 at 9:14