pombreda / formalchemy

Automatically exported from code.google.com/p/formalchemy
MIT License
0 stars 0 forks source link

DateFieldRender should renders years as str (patch) #71

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

fs.validate() seems to be the entry point..

What is the expected output? What do you see instead?

The expected output is in a string form without
the list type representation.

What version of the product are you using? On what operating system?

formalchemy (svn) on Linux Ubuntu 7.10 and Python 2.6

Please provide any additional information below.

I've attached a simple workaround below. Comments welcome :) 

To apply:

cd <formalchemy_trunk>
patch -p0 < fields-bad-yyyy.diff

Original issue reported on code.google.com by robillar...@gmail.com on 24 Feb 2009 at 4:56

Attachments:

GoogleCodeExporter commented 9 years ago
This patch breaks the unit tests, and indeed date years seem to behave 
correctly already.

If you have a specific case that is causing problems for you, please give a 
complete
example, including your model classes and fieldset configuration.

Original comment by jbel...@gmail.com on 28 Feb 2009 at 1:43

GoogleCodeExporter commented 9 years ago

Original comment by jbel...@gmail.com on 28 Feb 2009 at 1:43

GoogleCodeExporter commented 9 years ago
@jbelis:

I added a test case for this issue. I confirm it still unresolved
and can be repeated with a few lines of code. Unfortunately I cannot send
more because I first discovered this problem at work.

Moreover, the problem seems to be repeatable whenever the 'Dt--foo__year' 
key is of type "list". fs.rebind() should probably not accept this and
should raise an error, so that fs.validate() doesn't returns invalidated data.

Original comment by robillar...@gmail.com on 28 Feb 2009 at 4:06

Attachments:

GoogleCodeExporter commented 9 years ago
Please give a test case that exhibits the problem.  Obviously you can make one 
up
that is not your full model from work.

Original comment by jbel...@gmail.com on 4 Mar 2009 at 3:51

GoogleCodeExporter commented 9 years ago
Please stop the bs. Obviously it does exhibits the problem. And
whats up with that stubborn attitude ?  

Have a nice day,

erob

Original comment by robillar...@gmail.com on 4 Mar 2009 at 12:14

GoogleCodeExporter commented 9 years ago
I'm sorry that you think providing a test case of the problem is not worth your 
time.

Original comment by jbel...@gmail.com on 4 Mar 2009 at 1:28