no-edit config option do not respect "Gitit User's Guide" token

[GoogleCodeExporter]

What steps will reproduce the problem?
1. freshly install gitit
2. set no-edit: Help, Gitit User's Guide in default.conf
3. start gitit with -f default.conf

What is the expected output? What do you see instead?
edit link disappear in http://localhost:5001/Gitit%20User's%20Guide
/ edit link still appear in http://localhost:5001/Gitit%20User's%20Guide

What version of the product are you using? On what operating system?
0.7.3.1

Please provide any additional information below.
none

Original issue reported on code.google.com by nfjinj...@gmail.com on 21 Mar 2010 at 7:41

[GoogleCodeExporter]

I don't understand what you're seeing here.
You say the link disappears and that it still appears - which is it?

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 7:59

[GoogleCodeExporter]

Oh, I mean:

I expect the edit link to disappear,

but the edit link is still showing for the Gitit%20User's%20Guide page

Original comment by nfjinj...@gmail.com on 21 Mar 2010 at 8:05

[GoogleCodeExporter]

I'm guessing that you're using the cache, right?  I tried it myself, and 
briefly experienced 
what you're talking about, but it turned out to be the cached page that was 
showing. 
This is safe, because it would not allow you to update the page.
Try a hard reload (Ctrl-R).

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 8:08

[GoogleCodeExporter]

Thanks, I'm indeed using the cache option. After I set use-cache to no, edit 
link disappeared.

But it's more tricky here. 

If I then set cache to yes again, the edit link is still showing up, if I do 
Ctrl-R, 
nothing changes. Is this expected?

so what I did is: 

* set use-cache: yes
* change the no-edit field to include user guide
* restart server
* notice that edit link still appear
* set use-cache: no
* restart server
* notice edit link disappear
* set use_cache: yes
* restart server
* notice edit link appear
* hit ctrl+R
* edit link still appear

Original comment by nfjinj...@gmail.com on 21 Mar 2010 at 8:21

[GoogleCodeExporter]

I think the problem is that Ctrl-R is not bound to expireCache as advertised.
I'll look into that, but in the mean time there are two other ways you can 
manually 
expire the cache:  (1) hit /_expire/PAGENAME , (2) just delete files from the 
cache 
directory.  Let me know if that works -- if it does, then the only problem is 
with the 
Ctrl-R binding.

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 5:27

[GoogleCodeExporter]

I think this issue is fixed by 798dfc0edd57d6e1f90bf40d0e0af9fefef6614a.
There was a problem with UTF8 encoding of filenames in the Cache module, which 
I 
think I've fixed.

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 7:43

[GoogleCodeExporter]

Please let me know if Ctrl-R now works to expire your pages.

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 7:44

[GoogleCodeExporter]

I think that fixes it, is there supposed to be a delay of a few seconds or so, 
since after 
I changed the no-edit field, initially there was no effect no matter how hard I 
spam 
Ctrl-R, only after a few seconds the page reloads to a correct one and the 
effet took 
place. Same behavior on both firefox and chrome. Kind of fishy, but yeah, it 
fix it. 
Thanks :)

Original comment by nfjinj...@gmail.com on 21 Mar 2010 at 8:02

[GoogleCodeExporter]

I'm not experiencing that delay -- could be something with your server setup?
Anyway, I'll close this bug.
Note that you can always manually delete your cache directory when you change 
config 
options like that.

Original comment by fiddloso...@gmail.com on 21 Mar 2010 at 8:46

• Changed state: Fixed