Open GoogleCodeExporter opened 9 years ago
I'm not sure from the project page how to submit a patch, but this avoids the
build failure:
=== modified file 'src/signalhandler_unittest.sh'
--- src/signalhandler_unittest.sh 2012-06-21 21:07:21 +0000
+++ src/signalhandler_unittest.sh 2013-03-13 14:15:15 +0000
@@ -72,6 +72,13 @@
exit 0
fi
+# The symbols don't match on ARM.
+# We just skip the test for ARM.
+if [ `expr match \`uname -p\` "arm*"` ]; then
+ echo "PASS (We don't test the signal handler on ARM.)"
+ exit 0
+fi
+
# Test for a case the program kills itself by SIGSEGV.
GOOGLE_LOG_DIR=. $BINARY segv 2> signalhandler.out1
for pattern in SIGSEGV 0xdead main "Aborted at [0-9]"; do
Original comment by a...@octopull.co.uk
on 13 Mar 2013 at 2:36
Actually the test only passes for x86 and x86_64 (as per documentation), so
instead of doing :
if [ `expr match \`uname -p\` "ppc*"` ]; then
if [ `expr match \`uname -p\` "mips*"` ]; then
if [ `expr match \`uname -p\` "arm*"` ]; then
...
I think upstream should really state there intention in the test.
Original comment by mathieu.malaterre
on 13 Mar 2013 at 2:52
Original issue reported on code.google.com by
mathieu.malaterre
on 17 Dec 2012 at 11:46