pombreda / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

compile error on windows with gflags #60

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The error was reported earlier by another user on mail list, 
http://groups.google.com/group/google-glog/browse_thread/thread/f429a4a825894591

and I just met the same one as him.

I changed one line of code, and it seems be ok now, and here's the patch:

Index: src/windows/glog/logging.h

===================================================================

--- src/windows/glog/logging.h  (revision 90)

+++ src/windows/glog/logging.h  (working copy)

@@ -82,7 +82,7 @@

 #include <inttypes.h>           // a third place for uint16_t or u_int16_t
 #endif

-#if 0
+#if HAVE_LIB_GFLAGS
 #include <gflags/gflags.h>
 #endif

note that it only fix the dll build of glog, the static one seems have more 
problems related to gflags lib.

Original issue reported on code.google.com by frank28 on 16 Aug 2010 at 1:39

GoogleCodeExporter commented 9 years ago
FYI, I report the problem for static-link lib building related to gflags, and 
provide a rough solution.

http://code.google.com/p/google-gflags/issues/detail?id=37

Original comment by frank28 on 16 Aug 2010 at 10:34