pombreda / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
0 stars 1 forks source link

Remove logging of built-in mappings #177

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Whenever I use -Xiwyu -v7 to get an idea of IWYU's decisions, the contents are 
completely drowned in all the mapping messages:

  Adding mapping from <bits/a.out.h> to <a.out.h>
  Adding mapping from <bits/auxv.h> to <sys/auxv.h>
  Adding mapping from <bits/byteswap.h> to <byteswap.h>
  Adding mapping from <bits/cmathcalls.h> to <complex.h>
  Adding mapping from <bits/confname.h> to <unistd.h>
  Adding mapping from <bits/dirent.h> to <dirent.h>
  Adding mapping from <bits/dlfcn.h> to <dlfcn.h>
  ...

This patch removes them entirely, I don't see that we have much use for them. I 
could also be persuaded to move them to verbose level 8.

Original issue reported on code.google.com by kim.gras...@gmail.com on 22 Feb 2015 at 9:30

Attachments:

GoogleCodeExporter commented 9 years ago
I think it is better to keep this log line because there are a few cases when 
mapping is added not directly from mapping file, but according to some logic. I 
am talking about "internal/" and "asm/" cases. But I'm OK to move it to more 
verbose level. You can use verbosity levels in iwyu_globals.h as a guidance.

Original comment by vsap...@gmail.com on 23 Feb 2015 at 6:13

GoogleCodeExporter commented 9 years ago
Yes, after thinking about it, I agree.

Added new verbosity level 8, and used that in r608.

Original comment by kim.gras...@gmail.com on 2 Mar 2015 at 8:41