pombreda / libkml

Automatically exported from code.google.com/p/libkml
Other
0 stars 0 forks source link

Includes installed in wrong location for uriparser #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Write code that contains #include <kml/engine.h>
2. Compile
3.

What is the expected output? 
 - Successful compile

What do you see instead?
 - In file included from /usr/include/kml/engine/kml_uri.h:35,
                 from /usr/include/kml/engine.h:43,
                 from KmlUtilities.hpp:6,
                 from RawImage.hpp:4,
                 from RawImage.cpp:1:
/usr/include/kml/base/uri_parser.h:37:27: error: uriparser/Uri.h: No such
file or directory

What version of the product are you using? On what operating system?
 - 0.5.0, Linux

Did you run the unit test suite that comes with the project? Did all tests
pass?
 - N/A

Please provide any additional information below.
= Fixed with = 
Edit file: third_party/Makefile.am
Change Line 34:
uriparserinc = $(includedir)/kml/third_party/$(uriparser)/include

to

uriparserinc = $(includedir)/kml/third_party/$(uriparser)/include/uriparser

Original issue reported on code.google.com by GrantSco...@gmail.com on 18 Dec 2008 at 6:23

GoogleCodeExporter commented 9 years ago
uriparser/Uri.h really should not be in a publically distributed header.
use of uriparser is an internal implementation detail

the real fix is to separate the UriParser interface (.h) from
the implementation (in a new .cc) where only the .cc includes
uriparser/Uri.h

Original comment by bent.hag...@gmail.com on 10 Feb 2009 at 10:33

GoogleCodeExporter commented 9 years ago
Fixed in r495
http://code.google.com/p/libkml/source/detail?r=495

Original comment by kml.mash...@gmail.com on 10 Mar 2009 at 11:13

GoogleCodeExporter commented 9 years ago

Original comment by kml.mash...@gmail.com on 18 Mar 2009 at 9:33