pombreda / mozc

Automatically exported from code.google.com/p/mozc
0 stars 0 forks source link

Deprecate base/base.h #218

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
base/base.h, which had been there since the initial release of OSS Mozc (*1), 
was removed from code tree in r192.  If you derivative project is still having 
#include "base/base.h", please replace it with more specific header such as 
"base/compiler_specific.h" or "base/port.h".

*1: https://code.google.com/p/mozc/source/browse/trunk/src/base/base.h?r=10

Background:
In general, we don't want to have any *meta* include header that defines 
nothing but only includes some other headers.  Apparently, base/base.h has been 
fallen into this category.  Therefore we started the removal of base/base.h 
since June 2013.
As you can see the diff in r163, r178, and r185, we have eliminated tons of 
#include "base/base.h" from our code tree. Finally, in r192, we finally removed 
"base/port.h" from the repository.

After the release of r192, I heard some derivative projects were still relying 
on "base/base.h".  Sorry for the late notice.  I haven't noticed it.  Please 
replace it with more specific header such as "base/compiler_specific.h" or 
"base/port.h".

Thank you for your understanding.

Original issue reported on code.google.com by yukawa@google.com on 24 May 2014 at 6:30

GoogleCodeExporter commented 9 years ago

Original comment by yukawa@google.com on 26 May 2014 at 2:26