search

pombreda / pgreloaded

Automatically exported from code.google.com/p/pgreloaded
Other
0 stars 0 forks source link

SDL RWops ABI change - segfaults ensue #22

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Introduced in http://hg.libsdl.org/SDL/rev/b716011e53ce

Attached trivial patch so that it at least doesn't crash.

Original issue reported on code.google.com by llxxn...@gmail.com on 17 Nov 2012 at 5:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks; the latest changes on SDL2 from around the last 3+ weeks were not yet 
picked up.

Original comment by marcusvonappen@googlemail.com on 17 Nov 2012 at 8:21

GoogleCodeExporter commented 9 years ago 
I like this other patch better. 

Python filelikes do not usually have a .size() method, and calling _rwseek(0, 
RW_SEEK_END) is best left to the consumer.

So just return -1 if .size() isn't there.

Please review.

Original comment by llxxn...@gmail.com on 18 Nov 2012 at 7:25

Attachments:

GoogleCodeExporter commented 9 years ago 
This is solved in http://bitbucket.org/marcusva/py-sdl2 - do you need a final 
patch for pgreloaded? If not, I'd like to draw your attention to the project 
above.

Original comment by marcusvonappen@googlemail.com on 27 Apr 2013 at 6:36