pombreda / pybootchartgui

Automatically exported from code.google.com/p/pybootchartgui
GNU General Public License v3.0
0 stars 0 forks source link

command line behaviour should be identical to bootchart #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
To be able to replace easily bootchart utility (by symlinking bootchart to
pybootchartgui), pybootchartgui should have the same behaviour than
bootchart, when started with no parameter.

Attached patch fixes this issue.

Original issue reported on code.google.com by fcrozat@free.fr on 25 Sep 2009 at 10:34

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks. Committed in r138.

Just out of interest. How important is it to you that pybootchartgui keeps
compatibility with the java bootchart? 

Michael Meeks from OpenSUSE has some improvements for pybootchart gui that I 
think
will break compatibility eventually.

Best,
Anders

Original comment by anders.n...@gmail.com on 25 Sep 2009 at 6:17

GoogleCodeExporter commented 9 years ago
Here is a little of context :

in bootchart Mandriva package, I removed completely java part and replaced it 
with
pybootchartgui and created a symlink from pybootchartgui to bootchart, which is 
why I
wanted to keep a command line "compatibility".

Michael (or another SUSE guy) changed their bootchartd to call pybootchartgui in
auto-render mode but I'm expecting a lot of people to still call "bootchart" on 
CLI
without knowning we switched to our python rewrite.

Maybe we could add a "compat" mode switched on when pybootchartgui arg[0] is
"bootchart" or I could write a simple shell script to replace bootchart and call
pybootchartgui with the "correct" paramaters.

I simply choose the easiest path for now ;)

BTW, it would be nice for pybootchartgui to not try to connect to X when it just
write its output to image files, currently, it outputs some X11 error (but 
write the
correct file).

Original comment by fcrozat@free.fr on 26 Sep 2009 at 6:45

GoogleCodeExporter commented 9 years ago
Hi Frederic,

I think I would prefer if pybootchartgui was wrapped in a small shell script. 
It will 
make it easier to add features going forward. Also for pybootchartgui actually 
the 
best default is probably to launch the gui - not to write out the png, so I 
will 
change that pretty soon I think.

Best
Anders

Original comment by anders.n...@gmail.com on 4 Oct 2009 at 3:36

GoogleCodeExporter commented 9 years ago
Ok, I'll write a shell wrapper.

Original comment by fcrozat@free.fr on 4 Oct 2009 at 6:03