search

pombreda / pycomicmetathis

Automatically exported from code.google.com/p/pycomicmetathis
0 stars 0 forks source link

r19 issue - metadata not readable by CBL #5

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I can verify that there is metadata in the files by doing an "unzip *". But 
when I open my test files (clean Zip to CBZ) no metadata loads.

Original issue reported on code.google.com by cwald...@gmail.com on 9 Dec 2010 at 5:48

GoogleCodeExporter commented 9 years ago 
can you do "unzip -z file.cbz" (replacing file.cbz with the actual name of your 
CBZ files) and post the results here?

Original comment by andre.me...@gmail.com on 9 Dec 2010 at 6:04

GoogleCodeExporter commented 9 years ago 
See attached. Info from three different files.

Original comment by cwald...@gmail.com on 10 Dec 2010 at 3:09

Attachments:

GoogleCodeExporter commented 9 years ago 
it appears the zip comment is getting extra carriage returns and new lines 
inserted.  I'm not sure how to work around this.  One potential solution is to 
set your description text limit lower.  For your Detective Comics Annual 12 
example, it worked for me under 242 but failed at 243.

Original comment by andre.me...@gmail.com on 13 Dec 2010 at 2:41

GoogleCodeExporter commented 9 years ago 
Odd. I changed the description to false (so no description at all) and re-ran. 
It goes through just fine, although it'd be nice if the list of possible series 
were listed chronologically.

But the files still don't retain their metadata. In fact they don't retain any 
of the metadata gathered by the script.

This is what I get for Detective Comics Annual 12 after running the script...
Archive:  Detective Comics Annual 012.cbz

And this is what I get when I open the file with CBL...
Archive:  Detective Comics Annual 012.cbz
{"ComicBookInfo/1.0":{"title":"Detective Comics Annual 012","country":"United 
States","language":"English","rating":0},"appID":"ComicBookLover/999","lastModif
ied":"2010-12-13 05:47:34 +0000"}

Original comment by cwald...@gmail.com on 13 Dec 2010 at 5:48

GoogleCodeExporter commented 9 years ago 
have you recompiled zip with a larger comment size (as described at 
http://pixelverse.lefora.com/2010/11/23/cbr-to-cbz-conversion-with-commentstags-
intact-a-t/#post0 )?  If so, the latest version has an option to set the 
zipCommand.  when I set it to use the ziplong that I built following those 
instructions, it appears to work.  The code I've checked in uses the stock zip 
so it  won't work properly...

Original comment by andre.me...@gmail.com on 14 Dec 2010 at 5:01

GoogleCodeExporter commented 9 years ago 
Also, the series list is now chronological

Original comment by andre.me...@gmail.com on 14 Dec 2010 at 5:08

GoogleCodeExporter commented 9 years ago 
okay, i was using the default zip binary that ships with 10.6.5. I'm having 
problems building zip30 following the forum instructions though. I've got xcode 
installed, and i've got the path to /Developer/usr/bin/ in my .profile. when I 
run make I get a flood of warnings and errors from the zip.c file.

hrm. I'll work on this more later Tuesday morning while I'm at work. ;-)

Original comment by cwald...@gmail.com on 14 Dec 2010 at 6:48

GoogleCodeExporter commented 9 years ago 
Well, I'm unable to compile zip30 in 10.6.5 and xcode 3.2.5. I've left a 
message on the info-zip.org forums.

Argh.

Original comment by cwald...@gmail.com on 17 Dec 2010 at 4:35

GoogleCodeExporter commented 9 years ago 
I get the same issue described above. 

I'm running r26. 

I've successfully recompiled zip to use the larger comments field and changed 
the zipCommand option to use ziplong (however, the test file I'm using does not 
have any comments from Comic Vine). 

When I add the test file to CBL, no metadata appears.  

I've attached the metadata from unzipping the cbz.

Original comment by IntoThis...@gmail.com on 20 Dec 2010 at 5:34

Attachments:

GoogleCodeExporter commented 9 years ago 
I recompiled zip30 on another machine and that's working for me now.

I've run through several issues with no problems. I still have problems with 
Action Comics 8, 9, and 11 though. ComicBook Lover hangs trying to validate the 
metadata I assume since when I quit CBL I get the following message "Multiple 
validation errors occurred".

Looking better and better though. :-)

Original comment by cwald...@gmail.com on 20 Dec 2010 at 6:08

GoogleCodeExporter commented 9 years ago 
Here is the zip info on a few of the assets I've come across with the metadata 
validation errors. Out of a few hundred, only a couple dozen have exhibited the 
problem

Original comment by cwald...@gmail.com on 21 Dec 2010 at 6:06

Attachments:

GoogleCodeExporter commented 9 years ago 
I've added an indent of 0 to the JSON data (which puts each element on a 
newline) and it appears to have gone away for my test cases.  This leads me to 
believe CBL doesn't handle very long stings correctly, but when I look at 
records edited by CBL, all the metadata is on one line so it must... 

Does CBL actually hang for you?  The closest I can replicate is it just doesn't 
load the metadata.  

Either way, I've checked in changes that should work better.

Original comment by andre.me...@gmail.com on 23 Dec 2010 at 1:35

GoogleCodeExporter commented 9 years ago 
Maybe a bug in the latest build. I get an error while its trying to find a 
"_.txt" file when I try and run it on Action Comics Annual 8.

Processing :Action Comics Annual 008.cbz
/bin/sh: /Users/cwaldrip/Documents/Comics/: Is a directory
/bin/sh: /Users/cwaldrip/Documents/Comics/ Broken/Action Comics Annual/Action 
Comics Annual 008.cbz_.txt: No such file or directory
Traceback (most recent call last):
  File "/Users/cwaldrip/Downloads/pyComicMetaThis.py", line 735, in <module>
    main()
  File "/Users/cwaldrip/Downloads/pyComicMetaThis.py", line 594, in main
    processDir(dir)
  File "/Users/cwaldrip/Downloads/pyComicMetaThis.py", line 493, in processDir
    comicBookInfo = readCBI(dir, filename)
  File "/Users/cwaldrip/Downloads/pyComicMetaThis.py", line 303, in readCBI
    cbzComment = readComment(dir, filename)
  File "/Users/cwaldrip/Downloads/pyComicMetaThis.py", line 189, in readComment
    os.remove(txtFile2) 
OSError: [Errno 2] No such file or directory: 
'/Users/cwaldrip/Documents/Comics/ Broken/Action Comics Annual/Action Comics 
Annual 008.cbz_.txt'

Original comment by cwald...@gmail.com on 23 Dec 2010 at 4:09

GoogleCodeExporter commented 9 years ago 
CBL doesn't actually hang - it just sits there unable to process the metadata. 
I can quit it and it just warns me about malformed metadata.

Original comment by cwald...@gmail.com on 23 Dec 2010 at 4:10

GoogleCodeExporter commented 9 years ago 
Looks like my script doesn't like spaces in the path or filename.  I've just 
checked in a fix for this.  You might have some _.txt files that the previous 
version of the script failed to cleanup.

Original comment by andre.me...@gmail.com on 23 Dec 2010 at 4:36

GoogleCodeExporter commented 9 years ago 
Nope. Still get an error...

Processing :Action Comics Annual 008.cbz
/bin/sh: /Users/cwaldrip/Documents/Comics/\ Broken/Action\ Comics\ 
Annual/Action\ Comics\ Annual\ 008.cbz.txt: No such file or directory
/bin/sh: /Users/cwaldrip/Documents/Comics/\ Broken/Action\ Comics\ 
Annual/Action\ Comics\ Annual\ 008.cbz_.txt: No such file or directory
Traceback (most recent call last):
  File "../../pyComicMetaThis.py", line 732, in <module>
    main()
  File "../../pyComicMetaThis.py", line 591, in main
    processDir(dir)
  File "../../pyComicMetaThis.py", line 490, in processDir
    comicBookInfo = readCBI(dir, filename)
  File "../../pyComicMetaThis.py", line 300, in readCBI
    cbzComment = readComment(dir, filename)
  File "../../pyComicMetaThis.py", line 174, in readComment
    os.remove(txtFile)
OSError: [Errno 2] No such file or directory: 
'/Users/cwaldrip/Documents/Comics/\\ Broken/Action\\ Comics\\ Annual/Action\\ 
Comics\\ Annual\\ 008.cbz.txt'

Original comment by cwald...@gmail.com on 23 Dec 2010 at 5:31

GoogleCodeExporter commented 9 years ago 
How about now?  Either the filename needs to be quoted or the spaces need to be 
escaped.  I did both... which caused problems!  Now I'm just quoting the 
filenames.

Original comment by andre.me...@gmail.com on 23 Dec 2010 at 6:37

GoogleCodeExporter commented 9 years ago 
Using build r31, get the following error...

Traceback (most recent call last):
  File "/Users/cwaldrip/Documents/Comics/pyComicMetaThis.py", line 52, in <module>
    except ImportError: import simplejson
ImportError: No module named simplejson

Original comment by cwald...@gmail.com on 23 Dec 2010 at 7:00

GoogleCodeExporter commented 9 years ago 
that should work now.  I think I need a better exception handling on that one...

Original comment by andre.me...@gmail.com on 23 Dec 2010 at 8:34

GoogleCodeExporter commented 9 years ago 
Works (mostly). ;-)

All of my 'broken' files are working, but a couple of files still won't import, 
all from the same series (and the 4th issue won't even work with the script - 
like it doesn't exist on comicvine.com).

Here's the zip comments.

Archive:  Angel - Long Nights Journey 001.cbz
{
"lastModified": "2010-12-23 20:5357 +0000", 
"ComicBookInfo/1.0": {
"publisher": "Dark Horse Comics", 
"publicationYear": null, 
"publicationMonth": 1, 
"title": "", 
"series": "Angel: Long Night's Journey", 
"volume": 2002, 
"credits": [], 
"issue": "1"
}, 
"appID": "pyComicMetaThis.py/0.2e"
}

Original comment by cwald...@gmail.com on 23 Dec 2010 at 9:02

GoogleCodeExporter commented 9 years ago 
I've had great success with the latest build Only the occasional files aren't 
being scanned, but it's a very small minority. Sometimes I can rezip the files 
and they'll scan. But it is a very small minority (something like 1:1000).

Original comment by cwald...@gmail.com on 24 Dec 2010 at 7:07