search

pombreda / pysal

Automatically exported from code.google.com/p/pysal
Other
0 stars 0 forks source link

Write tests and documentation for lat2SW #124

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Add documentation, doctests and unit tests for lat2SW

Original issue reported on code.google.com by schmi...@gmail.com on 4 Jan 2011 at 8:31

GoogleCodeExporter commented 9 years ago 
change name to lat2SWMat

implies a sparse matrix not our W is returned

Original comment by sjsrey on 7 Jan 2011 at 9:35

GoogleCodeExporter commented 9 years ago 
create a new function in util called, "W_from_sprase_matrix"
changed lat2W to something like....
def lat2W(nrows=5,ncols=5,rook=True,id_type='int'):
     return W_from_sparse_matrix(lat2SW(nrow,ncols))
but handle id_type corrently.

This way we can keep lat2SW untouched, so if people only need the sparse.

Original comment by schmi...@gmail.com on 21 Jan 2011 at 4:17

GoogleCodeExporter commented 9 years ago 
this isn't clear to me any more what you have in mind. so i think we should 
wait on this till 1.2 when we refactor our W - or if you have a better grasp of 
what you want, go for it for 1.1.

Original comment by sjsrey on 27 Jan 2011 at 4:39

GoogleCodeExporter commented 9 years ago 
W_from_sparse_matrix turns out to be very slow.  We'll need to look at ways to 
optimize this for 1.2.  For now we can leave things as they are.

Docs and Tests added in r774

Original comment by schmi...@gmail.com on 27 Jan 2011 at 5:52