search

pombreda / pysal

Automatically exported from code.google.com/p/pysal
Other
0 stars 0 forks source link

streamline methods for different weights types #160

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
in part this is just a way for me to get familiar with the system,
but seriously, some weights types have methods that don't
make sense. for example, higher_order only makes sense for
binary weights, so for kernel weights, this should not be a method.
with all the new weights types, it may be a good idea to go over
this and eliminate methods that shouldn't be implemented for
a particular type of weight.
L.

Original issue reported on code.google.com by lanse...@gmail.com on 24 Jun 2011 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by lanse...@gmail.com on 24 Jun 2011 at 11:23

GoogleCodeExporter commented 9 years ago 
We can remove order and shimbel as methods of W since they are currently 
calling utility functions anyway.  Those functions can be called with a W as an 
argument but we may want to have some sanity checking on the weight type.

Original comment by sjsrey on 25 Jun 2011 at 8:32

GoogleCodeExporter commented 9 years ago 
Moving to 1.3 where we can take a closer look at this. For 1.2 the shimbel, 
order, and higher_order methods were removed since they were calling utility 
functions. Obtaining higher order W objects can now be done through functions 
by passing the relevant W as an argument to higher_order.

In 1.3 we still need to take a close look at the methods in W for similar 
refactoring.

Original comment by sjsrey on 13 Jul 2011 at 10:51

GoogleCodeExporter commented 9 years ago

Original comment by sjsrey on 9 Jan 2012 at 9:14

GoogleCodeExporter commented 9 years ago

Original comment by sjsrey on 31 Jul 2012 at 4:08

GoogleCodeExporter commented 9 years ago

Original comment by sjsrey on 8 Feb 2013 at 3:54