Finalize weights api

[GoogleCodeExporter]

set this for 1.0 so other modules can move on

Original issue reported on code.google.com by sjsrey on 26 Feb 2010 at 12:08

• Blocking: #61

[GoogleCodeExporter]

1. finalize api how we use weights
2. change init to use keywords instead of dict
3. document api

Original comment by sjsrey on 26 Feb 2010 at 12:09

[GoogleCodeExporter]

Fix the API for Distance Based weights too. (be consistent with contiguity).

Original comment by schmi...@gmail.com on 26 Feb 2010 at 12:22

[GoogleCodeExporter]

Charlie will double check that weigths.W API is final.
Charlie will change the __init__ for W.

Serge will make the buildContiguity, knnW, thresholdW and kernelW functions and 
declare when their API is 
final.

Serge and Charlie will do the unit tests together.

Serge will build StandAlone and implement the methods.

David will add Wsets.py

Myunghwa will build the utils.py and update the user functions to conform to 
the new API.

Charlie will deal with the import scheme.

Original comment by schmi...@gmail.com on 27 Feb 2010 at 12:59

[GoogleCodeExporter]

Updated the signature of W.__init__ from (self,data) to 
(self,neighbors,weights=None,id_order=None)
Changed the documentation in W's doc string to reflect new __init__ signature.
Fixed doc_tests to reflect new signature.

Running unit tests, still a few places that need to be fixed.  Will commit when 
all tests are passing (probably 
tomorrow morning).

**** If you commit any local changes before I commit these I can deal with any 
conflicts, otherwise it's on you 
to fix conflicts in your local changes.

Original comment by schmi...@gmail.com on 2 Mar 2010 at 12:25

[GoogleCodeExporter]

Fixed remaining tests, most problems in Distance Weights where this various 
weights are subclasses of W.  I 
believe we decided to change this so that these will all be functions that 
return a W instead of subclassing W. For 
now every test is passing.

Committing the changes.  And sending ticket to serge, to take care of the build 
functions.

Original comment by schmi...@gmail.com on 2 Mar 2010 at 11:06

• Added labels: Component-Logic

[GoogleCodeExporter]

build functions completed. 

DistanceWeights.py and ContiguityWeights.py are gone and replaced by 
Distance.py 
and Contiguity.py which have the various builder functions

user.py has the "userland" api

one issue is the Distance based weights that are constructed from shapefiles 
assume 
nongeographic coordinates, we don't currently have gcd functions in there. but 
beyond that, api for these builders should be considered closed to fixed. it 
would be 
nice to get feedback from other users of weights for any final changes.

Original comment by sjsrey on 18 Mar 2010 at 6:29

[GoogleCodeExporter]

updated all other modules that were using weights to reflect the api changes. 
sending 
ticket to charlie to work on import scheme, then we can do the unit tests 
together.

Original comment by sjsrey on 19 Mar 2010 at 12:24

[GoogleCodeExporter]

Original comment by sjsrey on 20 Mar 2010 at 6:02

• Added labels: Milestone-1.0

[GoogleCodeExporter]

Ok, pysal.weights.weights is gone.  W now lives at pysal.weights.W.

Sending back to serge to get start on the unit tests.

Original comment by schmi...@gmail.com on 26 Mar 2010 at 1:53

• Changed state: Started

[GoogleCodeExporter]

Move characteristics out of constructor since many of the attributes are  not 
necessarily needed all times. Also 
see issue 65

Original comment by sjsrey on 23 Apr 2010 at 9:35

[GoogleCodeExporter]

Closed, unit tests are a separate ticket (issue 72)

Original comment by sjsrey on 1 Jul 2010 at 2:52

• Changed state: Fixed