Local execution of isolates throws exception inside expand_directory_and_symlink

[GoogleCodeExporter]

Repro:
1. Build any .isolated in Chromium, e.g. browser_tests_run.
2. ./tools/swarming_client/isolate.py run -v -s 
out/Release/browser_tests.isolated

Expected:

Expect isolate to run.

Actual:

Throws the exception below.

Running the isolate from the isolate server works.

Thanks to hubbe@ for reporting this.

 INFO         isolate(685): CompleteState.load_isolate([HOMEDIR]/src/chrome/src, [HOMEDIR]/src/chrome/src/out/Release/gen/chrome/browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': ''}, False)
 INFO         isolate(156): normalize_path_variables([HOMEDIR]/src/chrome/src, {}, [HOMEDIR]/src/chrome/src/chrome)
 INFO  isolate_format( 57): determine_root_dir([HOMEDIR]/src/chrome/src/chrome, 1112 files) -> [HOMEDIR]/src/chrome/src
[------ Swarming Error ------]
Input directory [HOMEDIR]/src/chrome/src/out/Release/remoting/remoting.webapp 
must have a trailing slash
Traceback (most recent call last):
  File "./tools/swarming_client/isolate.py", line 1516, in main
    return dispatcher.execute(OptionParserIsolate(version=__version__), argv)
  File "[HOMEDIR]/src/chrome/src/tools/swarming_client/third_party/depot_tools/subcommand.py", line 242, in execute
    return command(parser, args[1:])
  File "./tools/swarming_client/isolate.py", line 1251, in CMDrun
    options, os.getcwd(), None, options.skip_refresh)
  File "./tools/swarming_client/isolate.py", line 888, in load_complete_state
    options.extra_variables, options.ignore_broken_items)
  File "./tools/swarming_client/isolate.py", line 762, in load_isolate
    ignore_broken_items)
  File "./tools/swarming_client/isolate.py", line 63, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File "[HOMEDIR]/src/chrome/src/tools/swarming_client/isolateserver.py", line 1535, in expand_directory_and_symlink
    'Input directory %s must have a trailing slash' % infile)
MappingError: Input directory 
[HOMEDIR]/src/chrome/src/out/Release/remoting/remoting.webapp must have a 
trailing slash
[----------------------------]

Original issue reported on code.google.com by kbr@chromium.org on 14 May 2014 at 1:11

[GoogleCodeExporter]

By the way, the error above is happening on Linux. Clean tree.

Original comment by kbr@chromium.org on 14 May 2014 at 1:20

[GoogleCodeExporter]

...and a component build.

Original comment by kbr@chromium.org on 14 May 2014 at 1:20

[GoogleCodeExporter]

I reproed. I was quite surprised that ninja -C out/Release browser_tests_run 
pass properly but "isolate.py run" fails. Will investigate.

Original comment by maruel@chromium.org on 15 May 2014 at 1:53

• Changed state: Started
• Added labels: Priority-1, Module-Client
• Removed labels: Priority-2

[GoogleCodeExporter]

Will look at it a bit later.

Original comment by maruel@chromium.org on 16 Jun 2014 at 6:52

• Changed state: Accepted
• Added labels: Priority-2
• Removed labels: Priority-1