Open GoogleCodeExporter opened 9 years ago
Okay, items 1, 2 and 3 from the previous list are done.
The commits were from r459-467 (except r462).
I won't change anything in the next 4 or 5 days.
The code is safe to play with again :)
Original comment by aureliojargas@gmail.com
on 12 Nov 2010 at 11:29
After many commits (search for PEP-8 in log messages), the code now is closer
to PEP-8 compliance.
There are only 3 errors (with multiple instances) pointed by the pep8.py script
(http://pypi.python.org/pypi/pep8)
$ pep8 txt2tags
txt2tags:88:11: E221 multiple spaces before operator
txt2tags:151:80: E501 line too long (142 characters)
txt2tags:244:11: E203 whitespace before ':'
$
This shows only the first line where the error appeared. For a detailed total
count of each error, one must use --statistics:
$ pep8 --statistics txt2tags
txt2tags:88:11: E221 multiple spaces before operator
txt2tags:151:80: E501 line too long (142 characters)
txt2tags:244:11: E203 whitespace before ':'
29 E203 whitespace before ':'
132 E221 multiple spaces before operator
149 E501 line too long (142 characters)
$
Fixing these, for now, is not really needed. E203 and E221 are visual
alignments for dictionary keys and variable setting. Fixing this will break the
following PEP-8 rule:
(1) When applying the rule would make the code less readable, even for
someone who is used to reading code that follows the rules.
E501 is about long lines, I'll let it untouched for now. I'm still not sure
breaking long lines with bring us any benefit.
Please, when writing new code, try to maintain PEP-8 compliance.
Run dist/check-code.sh before a commit (now checking PEP-8 too).
Original comment by aureliojargas@gmail.com
on 23 Nov 2010 at 10:59
Original issue reported on code.google.com by
aureliojargas@gmail.com
on 12 Nov 2010 at 8:59