search

pombreda / vcscommand

Automatically exported from code.google.com/p/vcscommand
0 stars 0 forks source link

set shellslash causes issues on windows #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
VCSCommit does not work on Windows because of shellslash (VCSCommand-
1.99.34 and older, Windows 7)

Steps to reproduce:
1. Edit file(s)
2. VCSCommit, :w
3. See output: VCSCommand:  Version control command failed:  ''svn'' is not 
recognized as an internal or external command,  operable program or batch 
file.
With verbose=5:
chdir(E:/Work/Sergey/home/vimfiles/syntax)
E:/Work/Sergey/home/vimfiles/syntax
Calling shell to execute: "'svn' commit --non-interactive -F 
"C:/Users/sergey/AppData/Local/Temp/VIEBA52.tmp" -- "vcscommit.vim" 
>C:/Users/sergey/AppData/Local/Temp/VIoBA53.tmp 2>&1"
chdir(E:/Work/Sergey/home/vimfiles/syntax)
E:/Work/Sergey/home/vimfiles/syntax
VCSCommand:  Version control command failed:  ''svn'' is not recognized as 
an internal or external command,  operable program or batch file.  

If I comment out set shellslash, all is working fine. Perhaps, it has been 
added for interoperability between Windows Vim and Cygwin or something like 
that.
The root cause for this is that shellescape() uses single quotes when 
shellslash is set, but Windows shell is unable to process single quotes 
unlike Unix shells.

Proposed solution: do not use shellslash (or at least, provide an option to 
disable this behaviour).

Original issue reported on code.google.com by sergey.k...@gmail.com on 26 Feb 2010 at 5:46

GoogleCodeExporter commented 9 years ago 
Unfortunately, shellslash was *added* for Windows, to (I believe) work around 
issues 
with temporary file names.  I'll look into it.

Original comment by bob.hies...@gmail.com on 26 Feb 2010 at 2:25

GoogleCodeExporter commented 9 years ago 
I am having this problem as well. Vim 7.2 on Windows XP, vcscommand 1.99.38.

I gained the ability to commit once I commented out the "set shellslash" line. 
I've
only played aroudn a bit, but there don't seem to be any problems (yet).

Original comment by areic...@gmail.com on 18 Mar 2010 at 4:34

GoogleCodeExporter commented 9 years ago 
I have removed the use of 'shellslash' in v1.99.39.  Please let me know if that 
causes 
any issues.

Original comment by bob.hies...@gmail.com on 29 Mar 2010 at 7:49

GoogleCodeExporter commented 9 years ago

Original comment by bob.hies...@gmail.com on 2 Apr 2010 at 3:45