pombreda / vcscommand

Automatically exported from code.google.com/p/vcscommand
0 stars 0 forks source link

[PATCH] :VCSAnnotate run in annotate buffer doesn't use current line's version. #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The detection of an existing annotate buffer is done via the filetype. A 
previous vcscommand release changed the ...annotate filetypes to all-lowercase, 
but the filetype names were kept in its old form, e.g. "HGannotate". Unless the 
user has set 'ignorecase', the == test fails, and the current line's version is 
not used when re-annotating from an annotate buffer. 

Attached patch updates all affected VCS implementations (all but Git). Note 
that the == test is influenced by the 'ignorecase' setting, and should in 
general be avoided in plugins; rather, use ==# (or ==? for a case-insensitive 
test) for all string comparisons. 

-- regards, ingo

Original issue reported on code.google.com by sw...@ingo-karkat.de on 30 Jul 2011 at 1:46

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, added for release (after changing to '==?') as:

http://repo.or.cz/w/vcscommand.git/commit/1493ee11dc714b0260ea810bddf7641db0aa46
fe

Original comment by bob.hies...@gmail.com on 3 Oct 2011 at 6:44