search

pombreda / vcscommand

Automatically exported from code.google.com/p/vcscommand
0 stars 0 forks source link

Closing diff buffer throws error instead of closing the buffer #85

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open a file under version control
2. see the diff of the file by issuing VCSVimDiff command
3. close the buffer showing the diff by issuing q command

What is the expected output? What do you see instead?

Expected output:
The buffer showing the diff should be closed and the original buffer 
should cover the entire window.

Output seen:

An error message is shown

"Error detected while processing function <SNR>15_VimDiffRestore:
line   26:
E119: Not enough arguments for function: setbufvar
Press ENTER or type command to continue"

The buffer showing the diff remains open 

What version of the product are you using? On what operating system?
OS: Ubuntu 10.10
Vim version 7.2.330
vcscommand version: 1.99.45

Please provide any additional information below.

Original issue reported on code.google.com by rob...@poovelil.org on 16 Nov 2011 at 4:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Once you open the VCSVimDiff, could you please capture the output of:

:echo t:vcsCommandVimDiffRestoreCmd

?

Original comment by bob.hies...@gmail.com on 30 Nov 2011 at 8:28

GoogleCodeExporter commented 9 years ago 
As per the request, pasting the output 

call setbufvar(1, '&diff', 0)|call setbufvar(1, '&foldcolumn', 0)|call 
setbufvar(1, '&foldenable', 1)|call setbufvar(1, '&foldmethod', 'manual')|call 
setbufvar(1, '&fol
dlevel', '0')|call setbufvar(1, '&scrollbind', 0)|call setbufvar(1, 
'&cursorbind', )|call setbufvar(1, '&wrap', 1)|if &foldmethod=='manual'|execute 
'normal! zE'|endif

Original comment by rob...@poovelil.org on 1 Dec 2011 at 4:29

GoogleCodeExporter commented 9 years ago 
Could you please try the attached replacement for vcscommand.vim?

The problem is likely that VIM 7.2 doesn't support &cursorbind, and the patched 
vcscommand protects against that.

Original comment by bob.hies...@gmail.com on 5 Dec 2011 at 4:16

Attachments:

GoogleCodeExporter commented 9 years ago 
I tried the replacement. It works. 

Thanks,
Robert

Original comment by rob...@poovelil.org on 6 Dec 2011 at 4:22

GoogleCodeExporter commented 9 years ago 
This is released in 1.99.46.

Original comment by bob.hies...@gmail.com on 6 Dec 2011 at 5:40