search

pomdtr / vscode-markdown-kroki

Adds Kroki support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=pomdtr.markdown-kroki
MIT License
21 stars 7 forks source link

Add prefix config option to allow a diagram prefix #1

Closed stevenj closed 1 year ago

stevenj commented 1 year ago

Tools like this: https://lib.rs/crates/mdbook-kroki-preprocessor also support kroki diagrams inside fenced code blocks. But in this case, they use a prefix in front of the diagram name. This PR adds an optional prefix parameter which allows easy compatibility with tools like this.

There was also a bug with handling of config values, so I had to fix that as well.

sabuty commented 1 year ago

Was just about to look into why the url config value set in the configuration is not used... thank you for the timely pull request to fix this alongside the new feature.

bvella commented 1 year ago

Hello and happy new year! Any chance the extension can be published with these changes? Thanks.

sabuty commented 1 year ago

Any support we can provide to continue this towards being published? Especially the configuration thing w.r.t. the custom server setting is a blocking issue for me...

brianphillips commented 1 year ago

@pomdtr would you be able to take a look and merge this PR if it fits within what you would like to do with this extension? My use-case is to have simpler compatibility with https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin which defaults to a fence prefix of kroki-

pomdtr commented 1 year ago

Sorry, not sure why but I missed the notification. I'll take a look tomorrow, thanks for you contribution.

pomdtr commented 1 year ago

Looks like I receive mails with mention, but not on new pull request. I'll fix that.