search

pomdtr / vscode-markdown-kroki

Adds Kroki support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=pomdtr.markdown-kroki
MIT License
21 stars 7 forks source link

Fetch diagram list #12

Closed joerocklin closed 5 months ago

joerocklin commented 5 months ago

This will update the list of supported diagram types from the configured kroki server, defaulting to the hardcoded list if unable to fetch for some reason. This should resolve issues like #7, and #11, along with future issues like them without needing to have extension updates coordinated with new versions of kroki.

I am still new to vscode extension development (and typescript), so suggestions for improvement are welcome!

joerocklin commented 5 months ago

That might work for the public kroki server (and be a good maintenance task overall for the project), but we have an internal server at work that differs from what the public kroki service offers. Since this checks with the configured server, and only once at activation, it provides a bit of a 'guarantee' that the supported list matches the target server.

pomdtr commented 5 months ago

Good point. I'm off this week, so I won't be able to review/merge the code until next week.

Please don't hesitate to ping me if necessary!