search

pomdtr / vscode-markdown-kroki

Adds Kroki support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=pomdtr.markdown-kroki
MIT License
21 stars 7 forks source link

Support empty kroki server URL in workspace settings #13

Open jankap opened 4 months ago

jankap commented 4 months ago

If I set the markdown-kroki.url option to "" in my workspace settings, the plugin says "invalid URL" at start, which makes sense I think. Is there a way to just inherit the user settings URL?

Thanks!

jankap commented 4 months ago

Rationale: I'm afraid to send corporate data to the default kroki url. I've set markdown-kroki.url in my user settings properly, I'd like to avoid always modifying the workspace settings which have precedence over user settings.

Thanks.

jankap commented 3 months ago

@pomdtr any chances to get this implemented? I think it would be sufficient to remove the default kroki url from the workspace and folder settings. User settings are sufficient. But now I have to overwrite every single workspace setting not to use the default kroki url, because it's pre-set there...

Thanks!

pomdtr commented 3 months ago

I'm not sure I properly understand the usecase. Why don't you set your custom kroki url in your user settings ?